From: Antonio Quartulli <a@unstable.cc>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org, mareklindner@neomailbox.ch
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function
Date: Mon, 9 May 2016 00:33:24 +0800 [thread overview]
Message-ID: <20160508163324.GC14515@prodigo> (raw)
In-Reply-To: <38489328.JjMjPGWWVN@sven-edge>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
On Fri, May 06, 2016 at 09:53:26AM +0200, Sven Eckelmann wrote:
> So you either have to add it to kernel-doc or do it differently.
Thanks for checking this. I will split the structure in real substructures with
their own definition and document the fields there.
About the result from IWUY: any easy way to run it locally ? I tried to run it
by specifying the IWYU path via CC=, but I get way more noisy result that what
you reported in your previous email. I'd like to learn this so that I can easily
understand which patch requires which include.
On top of that, the results you posted says that I should include
<linux/stddef.h> in bat_v.c, but it already included in that file. no?
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-08 16:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 18:46 [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 2/7] batman-adv: move GW mode and selection class to private data structure Antonio Quartulli
2016-05-06 1:06 ` Marek Lindner
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 3/7] batman-adv: make the GW selection class algorithm specific Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: split routing API data structure in subobjects Antonio Quartulli
2016-05-06 1:10 ` Marek Lindner
2016-05-06 1:20 ` Marek Lindner
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 5/7] batman-adv: statically print MAX TQ value in gateway table header Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: make GW election code protocol specific Antonio Quartulli
2016-05-05 18:46 ` [B.A.T.M.A.N.] [PATCH 7/7] batman-adv: B.A.T.M.A.N. V - implement GW selection logic Antonio Quartulli
2016-05-05 20:17 ` [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function Sven Eckelmann
2016-05-06 2:34 ` Antonio Quartulli
2016-05-06 7:23 ` Sven Eckelmann
2016-05-06 7:53 ` Sven Eckelmann
2016-05-08 16:33 ` Antonio Quartulli [this message]
2016-05-08 16:59 ` Sven Eckelmann
2016-05-15 9:01 ` Sven Eckelmann
2016-05-06 1:03 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160508163324.GC14515@prodigo \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox