From: Antonio Quartulli <a@unstable.cc>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: init ELP tweaking options only once
Date: Mon, 9 May 2016 22:20:15 +0800 [thread overview]
Message-ID: <20160509142015.GL3945@prodigo.futur3.it> (raw)
In-Reply-To: <1643067.4fJX8kxc6U@voltaire>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Mon, May 09, 2016 at 09:10:44PM +0800, Marek Lindner wrote:
> Am I right assuming you're not testing with Openwrt ? I suspect it is netifd
> that removes the interface from batX entirely on ifconfig down. That might not
> be the same on your system. I can reword the commit message to not mention
> interface down if you like.
You are right - I was not using netifd and so my simple "ifdown & ifup" was not
enough to trigger the reset.
Still, I do understand that your point is to avoid resetting the elp_interval
and throughput_override more than once during the hard_iface life span.
This said, I think your patch is fine, but the commit message should be
re-arranged in order to avoid stating that "ifdown & ifup" is a way to trigger
the "misbehaviour".
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-05-09 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 23:47 [B.A.T.M.A.N.] [PATCH] batman-adv: init ELP tweaking options only once Marek Lindner
2016-05-08 15:41 ` Antonio Quartulli
2016-05-09 7:32 ` Marek Lindner
2016-05-09 10:45 ` Antonio Quartulli
2016-05-09 13:10 ` Marek Lindner
2016-05-09 14:20 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509142015.GL3945@prodigo.futur3.it \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox