Re: [B.A.T.M.A.N.] [PATCH v6 01/11] batman-adv: Handle parent interfaces in a different netns

Andrew Lunn
2016-05-17T12:18:35Z

> I think I removed this multiple times but this misalignment seems to be
> immortal:
>
> > return (dev1_parent_iflink == dev2->ifindex) &&
> > - (dev2_parent_iflink == dev1->ifindex);
> > + (dev2_parent_iflink == dev1->ifindex) &&
> > + net_eq(dev1_parent_net, net2) &&
> > + net_eq(dev2_parent_net, net1);

According to checkpatch and emacs, it is also correct as it is :-)

If you really want to enforce some other arbitrary white space
alignment policy than checkpatch.pl, it would help if the scripts you
are using are placed into ./tools, just like checkpatch.pl is. Better
still, provide patches to checkpatch.pl. You should also put all your
other tools there. Checkpatch mostly works because it is easily
available, making it easy to push back against when people don't use
it. Developing code for BATMAN is easy, but making it pass all your
arbitrary style checks, header file requirements, structure forward
declaration, negative value kerneldoc function headers, etc is hard
and takes much much longer than developing the code. Putting these
scripts at the figures of the developers,
./scripts/batadv-checkpatch.pl, and you stand a better chance of
compliance.

I'm actually getting close to the point where i'm going to give up.

Andrew