Re: [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support

Andrew Lunn
2016-05-16T20:06:37Z

On Mon, May 16, 2016 at 08:58:13PM +0200, Sven Eckelmann wrote:
> On Monday 16 May 2016 19:27:58 Andrew Lunn wrote:
> > * No change to code indentation. I consider it a false positive. The
> > code is more readable the way it is, checkpatch is happy, and it
> > does not violate anything in CodingStyle, as far as i can see.
>
> @Antonio, @Marek, @Simon: Do you want to allow free-form alignments like this?
>
> if (batadv_iv_ogm_neigh_dump_hardif(
> msg, portid, cb->nlh->nlmsg_seq,
> bat_priv, hard_iface, &idx)) {
> i_hardif--;
> break;
> }

It is not fully free-form, however i cannot tell you exactly where it
comes from. If you have emacs do auto indent, using the linux kernel
indentation style, that is where emacs puts it.

Andrew