Re: [B.A.T.M.A.N.] [PATCH v6 00/11] netns and netlink support

Sven Eckelmann
2016-05-16T18:58:13Z

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

On Monday 16 May 2016 19:27:58 Andrew Lunn wrote:
> * No change to code indentation. I consider it a false positive. The
> code is more readable the way it is, checkpatch is happy, and it
> does not violate anything in CodingStyle, as far as i can see.

@Antonio, @Marek, @Simon: Do you want to allow free-form alignments like this?

if (batadv_iv_ogm_neigh_dump_hardif(
msg, portid, cb->nlh->nlmsg_seq,
bat_priv, hard_iface, &idx)) {
i_hardif--;
break;
}

I just know that this strict form was requested [1] (enforced!!!) by the
Linux net maintainer David Miller (and some other people but I just link
this because the discussion got really "juicy").

And to your "no change to code indentation". There is definitely one in your
latest patchset. It introduces a new free-form alignment to
batadv_iv_ogm_neigh_dump

if (i_hardif_s == 0) {
if (batadv_iv_ogm_neigh_dump_hardif(
msg, portid, cb->nlh->nlmsg_seq,
bat_priv, single_hardif, &idx) == 0)
i_hardif++;
}

Kind regards,
Sven

[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2011-December/005932.html

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]