From: Andrew Lunn <andrew@lunn.ch>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support
Date: Tue, 17 May 2016 15:58:20 +0200 [thread overview]
Message-ID: <20160517135820.GA25569@lunn.ch> (raw)
In-Reply-To: <1646180.Hz16yHrbtt@sven-edge>
> headers ecsv/netlink
> --------------------
>
> diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
> index 25fd4be..c5e6db5 100644
> --- a/net/batman-adv/bat_v.c
> +++ b/net/batman-adv/bat_v.c
> @@ -19,9 +19,9 @@
> #include "main.h"
>
> #include <linux/bug.h>
> +#include <linux/cache.h>
> #include <linux/errno.h>
> #include <linux/if_ether.h>
> -#include <linux/cache.h>
> #include <linux/init.h>
> #include <linux/jiffies.h>
> #include <linux/netdevice.h>
So this is i think a false positive. Linus moved cache.h according the
git blame. Nothing to do with my patch.
> diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
> index 949a048..e0fd914 100644
> --- a/net/batman-adv/netlink.c
> +++ b/net/batman-adv/netlink.c
> @@ -36,10 +36,10 @@
> #include <net/sock.h>
> #include <uapi/linux/batman_adv.h>
>
> -#include "originator.h"
> #include "bridge_loop_avoidance.h"
> #include "gateway_client.h"
> #include "hard-interface.h"
> +#include "originator.h"
> #include "soft-interface.h"
> #include "translation-table.h"
This one is interesting. I copied this from your
rebased_split_netlink/v4-0008-batman-adv-netlink-add-originator-and-neighbor-ta.patch
I did consider changing the order, but since you wrote it that way, it
must be O.K.
> diff --git a/net/batman-adv/netlink.h b/net/batman-adv/netlink.h
> index ef861db..fac7d91 100644
> --- a/net/batman-adv/netlink.h
> +++ b/net/batman-adv/netlink.h
> @@ -18,12 +18,9 @@
> #ifndef _NET_BATMAN_ADV_NETLINK_H_
> #define _NET_BATMAN_ADV_NETLINK_H_
>
> #include "main.h"
>
> -#include <linux/compiler.h>
> -#include <linux/genetlink.h>
> #include <net/genetlink.h>
> -#include <net/netlink.h>
>
> struct nlmsghdr;
Another false positive. These are from:
9492a25881c75ab9910328ff27834707c83df124
which has your Signed-off-by.
So overall, nothing useful in this report.
Andrew
prev parent reply other threads:[~2016-05-17 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 16:08 [B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 01/11] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 02/11] batman-adv: Suppress debugfs entries for netns's Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 03/11] batman-adv: netlink: add routing_algo query Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 04/11] batman-adv: netlink: hardif query Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 05/11] batman-adv: netlink: add translation table query Andrew Lunn
2016-05-16 16:41 ` Sven Eckelmann
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 06/11] batman-adv: netlink: add originator and neighbor table queries Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 07/11] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations Andrew Lunn
2016-05-16 16:44 ` Sven Eckelmann
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 08/11] batman-adv: add B.A.T.M.A.N. V " Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 09/11] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 10/11] batman-adv: add B.A.T.M.A.N. Dump BLA claims " Andrew Lunn
2016-05-16 16:41 ` Sven Eckelmann
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 11/11] batman-adv: Indicate netlink socket can be used with netns Andrew Lunn
2016-05-16 17:42 ` [B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support Sven Eckelmann
2016-05-17 13:58 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517135820.GA25569@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox