Re: [B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support

Sven Eckelmann
2016-05-16T17:42:09Z

[-- Attachment #1: Type: text/plain, Size: 2935 bytes --]

On Monday 16 May 2016 18:08:41 Andrew Lunn wrote:
> * Complete all the kerneldoc cut/paste work requested by Sven.

Hihi, thank you :)

It would have been nice when you would also have added a comment about all the
other changes. I've noticed:

* added missing attribute BATADV_ATTR_THROUGHPUT to the policy (thanks)
* batadv_netlink_get_ifindex was moved from netlink.h to netlink.c

here some more detailed things (not really relevant)

* added originator.h to the wrong place in netlink.c
* some different line breaks in batadv_iv_ogm_neigh_dump_neigh
("genlmsg_put(msg, portid, seq, ....").
* similar changes was done in batadv_algo_dump_entry
* extra linebreak in batadv_netlink_dump_hardifs for
batadv_netlink_get_ifindex
* extra linebreak in batadv_tt_local_dump_entry for genlmsg_put
* extra linebreak in batadv_tt_global_dump_subentry for genlmsg_put

Name of failed tests
====================

* bracket_align ecsv/netlink ./net/batman-adv/bat_iv_ogm.c
* headers ecsv/netlink

Output of different failed tests
================================

bracket_align ecsv/netlink ./net/batman-adv/bat_iv_ogm.c
--------------------------------------------------------

Found wrong alignment at ./net/batman-adv/bat_iv_ogm.c:2375, was 37 but expected 61
Found wrong alignment at ./net/batman-adv/bat_iv_ogm.c:2376, was 37 but expected 61

headers ecsv/netlink
--------------------

diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
index 25fd4be..c5e6db5 100644
--- a/net/batman-adv/bat_v.c
+++ b/net/batman-adv/bat_v.c
@@ -19,9 +19,9 @@
#include "main.h"

#include <linux/bug.h>
+#include <linux/cache.h>
#include <linux/errno.h>
#include <linux/if_ether.h>
-#include <linux/cache.h>
#include <linux/init.h>
#include <linux/jiffies.h>
#include <linux/netdevice.h>
diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index 949a048..e0fd914 100644
--- a/net/batman-adv/netlink.c
+++ b/net/batman-adv/netlink.c
@@ -36,10 +36,10 @@
#include <net/sock.h>
#include <uapi/linux/batman_adv.h>

-#include "originator.h"
#include "bridge_loop_avoidance.h"
#include "gateway_client.h"
#include "hard-interface.h"
+#include "originator.h"
#include "soft-interface.h"
#include "translation-table.h"

diff --git a/net/batman-adv/netlink.h b/net/batman-adv/netlink.h
index ef861db..fac7d91 100644
--- a/net/batman-adv/netlink.h
+++ b/net/batman-adv/netlink.h
@@ -18,12 +18,9 @@
#ifndef _NET_BATMAN_ADV_NETLINK_H_
#define _NET_BATMAN_ADV_NETLINK_H_

#include "main.h"

-#include <linux/compiler.h>
-#include <linux/genetlink.h>
#include <net/genetlink.h>
-#include <net/netlink.h>

struct nlmsghdr;

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]