From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Marek Lindner <mareklindner@neomailbox.ch>,
b.a.t.m.a.n@lists.open-mesh.org,
Antonio Quartulli <a@unstable.cc>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 3.16 046/114] batman-adv: Fix broadcast/ogm queue limit on a removed interface
Date: Mon, 13 Jun 2016 21:26:43 +0200 [thread overview]
Message-ID: <20160613192643.GJ3293@otheros> (raw)
In-Reply-To: <lsq.1465842997.536267398@decadent.org.uk>
On Mon, Jun 13, 2016 at 07:36:37PM +0100, Ben Hutchings wrote:
> 3.16.36-rc1 review patch. If anyone has any objections, please let me know.
>
Hi Ben,
This one looks weird. The version you added for 3.2.81-rc1 looked
better.
Cheers, Linus
> ------------------
>
> From: Linus Lüssing <linus.luessing@c0d3.blue>
>
> commit c4fdb6cff2aa0ae740c5f19b6f745cbbe786d42f upstream.
>
> When removing a single interface while a broadcast or ogm packet is
> still pending then we will free the forward packet without releasing the
> queue slots again.
>
> This patch is supposed to fix this issue.
>
> Fixes: 6d5808d4ae1b ("batman-adv: Add missing hardif_free_ref in forw_packet_free")
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> [sven@narfation.org: fix conflicts with current version]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> net/batman-adv/send.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- a/net/batman-adv/send.c
> +++ b/net/batman-adv/send.c
> @@ -638,6 +638,12 @@ batadv_purge_outstanding_packets(struct
>
> if (pending) {
> hlist_del(&forw_packet->list);
> + if (!forw_packet->own)
> + atomic_inc(&bat_priv->bcast_queue_left);
> +
> + if (!forw_packet->own)
> + atomic_inc(&bat_priv->batman_queue_left);
> +
> batadv_forw_packet_free(forw_packet);
> }
> }
>
parent reply other threads:[~2016-06-13 19:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <lsq.1465842997.536267398@decadent.org.uk>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613192643.GJ3293@otheros \
--to=linus.luessing@c0d3.blue \
--cc=a@unstable.cc \
--cc=akpm@linux-foundation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox