From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: Remove orig_node reference handling from send_skb_unicast
Date: Mon, 27 Jun 2016 05:55:45 +0200 [thread overview]
Message-ID: <20160627035545.GO4407@otheros> (raw)
In-Reply-To: <1466982121-3504-1-git-send-email-sven@narfation.org>
On Mon, Jun 27, 2016 at 01:02:01AM +0200, Sven Eckelmann wrote:
> The function batadv_send_skb_unicast is not acquiring a reference for an
> orig_node nor removing it from any datastructure. It still reduces the
> reference counter for an object which is still in the hands of the caller.
>
> This is confusing and can lead to problems in the reference handling in the
> caller function.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
I like it, indeed easier to read, especially for the multicast
part.
Maybe make it a "This is confusing and could lead to ... in the future." to
avoid people misreading it as a fix?
> diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c
> index 729deec..44be408 100644
> --- a/net/batman-adv/send.c
> +++ b/net/batman-adv/send.c
> @@ -362,8 +362,6 @@ int batadv_send_skb_unicast(struct batadv_priv *bat_priv,
The kernel doc of batadv_send_skb_unicast seems to need an update,
too ("s/ and release a reference to this orig_node//").
prev parent reply other threads:[~2016-06-27 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 23:02 [B.A.T.M.A.N.] [PATCH v2] batman-adv: Remove orig_node reference handling from send_skb_unicast Sven Eckelmann
2016-06-27 3:55 ` Linus Lüssing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160627035545.GO4407@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox