From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH v3] batman-adv: Remove orig_node reference handling from send_skb_unicast
Date: Tue, 28 Jun 2016 04:14:41 +0200 [thread overview]
Message-ID: <20160628021441.GT4407@otheros> (raw)
In-Reply-To: <1467008142-3797-1-git-send-email-sven@narfation.org>
On Mon, Jun 27, 2016 at 08:15:42AM +0200, Sven Eckelmann wrote:
> The function batadv_send_skb_unicast is not acquiring a reference for an
> orig_node nor removing it from any datastructure. It still reduces the
> reference counter for an object which is still in the hands of the caller.
>
> This is confusing and can lead in the future to problems in the reference
> handling of the caller function.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v3:
> - adjust commit message to sound less like an fix (thanks Linus)
> - Remove " and release a reference to this orig_node" from kerneldoc of
> batadv_send_skb_unicast (thanks Linus)
> v2:
> - remove bogus multicast example
> - remove Fixes:
> ---
Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>
next prev parent reply other threads:[~2016-06-28 2:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 6:15 [B.A.T.M.A.N.] [PATCH v3] batman-adv: Remove orig_node reference handling from send_skb_unicast Sven Eckelmann
2016-06-28 2:14 ` Linus Lüssing [this message]
2016-07-14 10:06 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628021441.GT4407@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox