Re: [B.A.T.M.A.N.] Patch to add mesh_no_rebroadcast

Ruben Wisniewski
2015-05-17T09:16:59Z

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

Am Sun, 17 May 2015 09:11:18 +0200
schrieb Sven Eckelmann <sven@narfation.org>:

> > Why are you sending a patch from Linus? And this patch doesn't
> > apply on current master or next.
>
> Just to make it more clear: I think it is not a problem to pick up
> some old patch from someone else when the original author has no
> problem with it. But taking a patch from someone else and then
> without any additional information claiming to be the author is a
> rather bad move.
It is a old patch which is fixed to apply to the latest stable version.

I talk to Simon yesterday, that it would be nice if the freifunker does
not need to ship this patch in any installation, since we start to setup
custom repos with this patch included and so on...

Else all freifunk-firmwares include this patch, this should be stable.

> It is even worse that the informative commit subject + message was
> dropped. There is also no information what you've changed before your
> signed-off-by (which is also missing).
Yes, I removed it, since the last patches I found on this mailinglist
does not have this information-part. So I thought this is the given
form for this mailinglist. (There is no information about that on the
mailinglist site).

> Btw. here is the original patch and the discussion
> http://thread.gmane.org/gmane.org.freifunk.batman/10503

I know this patch and discussion, I've read it yesterday with Simon and
he asked me to send our version of the patch to the mailinglist.

Best regards

Ruben

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 307 bytes --]