From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: restructure rebroadcast counter into forw_packet API
Date: Thu, 9 Feb 2017 11:20:01 +0100 [thread overview]
Message-ID: <20170209102001.GH4629@otheros> (raw)
In-Reply-To: <1502082.JgMhZiz8zA@bentobox>
On Mon, Feb 06, 2017 at 11:25:00AM +0100, Sven Eckelmann wrote:
> I like this change but have some questions (but no time to check it). Is cb
> initialized when a new skbuff is allocated?
Hm, good point. It looks like skb->cb is set to zero for newly
allocated skbs via a memset down to skb->tail. However, I could
not find anything resetting it to zero in net/core/dev.c, so there
could potentially be an issue.
It seems like network-coding.c might have the same issue already
for skb::cb::decoded.
next prev parent reply other threads:[~2017-02-09 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 13:57 [B.A.T.M.A.N.] [PATCH 0/6] batman-adv: broadcast packet aggregation Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: Allow TVLVs greater than 128 bytes Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: aggregation packet reception Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: aggregation packet queueing and transmission Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: privatize forw_packet skb assignment Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: restructure rebroadcast counter into forw_packet API Linus Lüssing
2017-02-06 10:25 ` Sven Eckelmann
2017-02-09 10:20 ` Linus Lüssing [this message]
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: do not aggregate rebroadcasts in the same packet Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209102001.GH4629@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox