Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Keep fragments equally sized

["Linus Lüssing" <linus.luessing@c0d3.blue>]

On Sun, Feb 12, 2017 at 11:26:34AM +0100, Sven Eckelmann wrote:
> The batman-adv fragmentation packets have the design problem that they
> cannot be refragmented. This often leads to problems when networks are
> incorrectly configured and don't use a common MTU.
> 
> The sender could for example fragment a 1500 byte packet to fit in a 1280
> bytes large MTU. This would create a 1280 large packet and a 284 bytes
> large packet. But the next hop is then not able to transport 1280 bytes to
> its next hop. The 1280 byte large packet will be dropped but the 284 bytes
> large packet will still be forwarded to its destination.
> 
> This can partly being avoided by splitting packets more equally. In this
> example, the two 782 bytes large packets could both potentially reach its
> destination.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> This patch is meant to enter master together with
> https://patchwork.open-mesh.org/patch/16933/
> 
>  net/batman-adv/fragmentation.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)

Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>