From: Antonio Quartulli <a@unstable.cc>
To: Sven Eckelmann <sven@narfation.org>,
Simon Wunderlich <sw@simonwunderlich.de>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v7 1/5] batman-adv: prevent multiple ARP replies sent by gateways if dat enabled
Date: Thu, 16 Feb 2017 23:13:48 +0800 [thread overview]
Message-ID: <20170216151348.GM12961@prodigo.lan> (raw)
In-Reply-To: <20170206114823.GG12187@prodigo.lan>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
Hi,
On Mon, Feb 06, 2017 at 07:48:23PM +0800, Antonio Quartulli wrote:
> Hi,
>
> On Mon, Feb 06, 2017 at 10:56:25AM +0100, Sven Eckelmann wrote:
> > It is therefore currently unknown how to continue from here. Antonio, please
> > provide a statement what we should do with the patches.
>
> There were two issues here:
> 1) the code was not really following the kernel style and I started my branch to
> "smoothen" it a little bit and possibly re-propose it to the mailing list;
>
I pushed my ordex/bla_dat branch after rebasing it on top of current master.
Patch 1 and 2 are ok for me.
The doubts I had were about the rest, which is mostly about rearrangement of
BLA.
@Simon, I think here I'd need you to give a deep look to understand what could
possibly go wrong in the cases described. These changes may violate some of the
scenarios fixed by BLA..
Could you please have a look?
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-02-16 15:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 11:20 [B.A.T.M.A.N.] [PATCH v7 1/5] batman-adv: prevent multiple ARP replies sent by gateways if dat enabled Sven Eckelmann
2016-09-05 11:20 ` [B.A.T.M.A.N.] [PATCH v7 2/5] batman-adv: prevent duplication of ARP replies when DAT is used Sven Eckelmann
2016-09-05 11:20 ` [B.A.T.M.A.N.] [PATCH v7 3/5] batman-adv: drop unicast packets from other backbone gw Sven Eckelmann
2016-09-05 11:20 ` [B.A.T.M.A.N.] [PATCH v7 4/5] batman-adv: changed debug messages for easier bla debugging Sven Eckelmann
2016-09-05 11:20 ` [B.A.T.M.A.N.] [PATCH v7 5/5] batman-adv: handle race condition for claims between gateways Sven Eckelmann
2016-09-05 11:23 ` [B.A.T.M.A.N.] [PATCH v7 0/5] batman-adv: prevent multiple ARP replies sent by gateways if dat enabled Sven Eckelmann
2016-09-08 5:11 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2016-09-08 5:43 ` Sven Eckelmann
2017-02-06 9:56 ` [B.A.T.M.A.N.] [PATCH v7 1/5] " Sven Eckelmann
2017-02-06 11:48 ` Antonio Quartulli
2017-02-16 15:13 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216151348.GM12961@prodigo.lan \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox