From: Philipp Psurek <philipp.psurek@gmail.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH 1/2] batctl: change PATH_BUFF_LEN to maximal possible value
Date: Tue, 13 Jun 2017 10:25:59 +0200 [thread overview]
Message-ID: <20170613082600.24910-2-philipp.psurek@gmail.com> (raw)
In-Reply-To: <20170613082600.24910-1-philipp.psurek@gmail.com>
The output of
snprintf(path_buff, PATH_BUFF_LEN, SYS_ROUTING_ALGO_FMT, iface_dir->d_name)
in sys.c can be between 34 and 289 bytes and should not write into a
destination of size 200.
Signed-off-by: Philipp Psurek <philipp.psurek@gmail.com>
---
functions.c | 2 +-
functions.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/functions.c b/functions.c
index 2239440..8337ee8 100644
--- a/functions.c
+++ b/functions.c
@@ -59,7 +59,7 @@
#include "debugfs.h"
#include "netlink.h"
-#define PATH_BUFF_LEN 200
+#define PATH_BUFF_LEN 289
static struct timespec start_time;
static char *host_name;
diff --git a/functions.h b/functions.h
index eca1406..c0a02a8 100644
--- a/functions.h
+++ b/functions.h
@@ -31,7 +31,7 @@
#define ETH_STR_LEN 17
#define BATMAN_ADV_TAG "batman-adv:"
-#define PATH_BUFF_LEN 200
+#define PATH_BUFF_LEN 289
/* return time delta from start to end in milliseconds */
void start_timer(void);
--
2.13.0
next prev parent reply other threads:[~2017-06-13 8:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 17:09 [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Philipp Psurek
2017-06-01 8:34 ` Simon Wunderlich
2017-06-03 2:14 ` Philipp Psurek
2017-06-03 3:12 ` [B.A.T.M.A.N.] [PATCH] batctl: suppress implicit-fallthrough compiler warning Philipp Psurek
2017-06-03 10:13 ` Philipp Psurek
2017-06-03 10:31 ` Philipp Psurek
2017-06-03 3:40 ` [B.A.T.M.A.N.] [PATCH] batctl: change PATH_BUFF_LEN to maximal possible value Philipp Psurek
2017-06-13 8:25 ` [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Philipp Psurek
2017-06-13 8:25 ` Philipp Psurek [this message]
2017-06-13 8:49 ` [B.A.T.M.A.N.] [PATCH 1/2] batctl: change PATH_BUFF_LEN to maximal possible value Simon Wunderlich
2017-06-13 8:26 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: suppress implicit-fallthrough compiler warning Philipp Psurek
2017-06-13 8:48 ` Simon Wunderlich
2017-06-13 10:39 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: suppress implicit-fallthrough compiler Philipp Psurek
2017-06-13 10:39 ` [B.A.T.M.A.N.] [PATCH] batctl: suppress implicit-fallthrough compiler warning Philipp Psurek
2017-06-13 11:08 ` [B.A.T.M.A.N.] [PATCH 2/2] " Philipp Psurek
2017-06-13 11:08 ` [B.A.T.M.A.N.] [PATCH] " Philipp Psurek
2017-06-13 11:46 ` Simon Wunderlich
2017-06-13 11:53 ` Sven Eckelmann
2017-06-13 11:55 ` Sven Eckelmann
2017-06-13 12:25 ` Philipp Psurek
2017-06-13 8:42 ` [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613082600.24910-2-philipp.psurek@gmail.com \
--to=philipp.psurek@gmail.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox