From: Philipp Psurek <philipp.psurek@gmail.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: suppress implicit-fallthrough compiler
Date: Tue, 13 Jun 2017 12:39:15 +0200 [thread overview]
Message-ID: <20170613103916.27299-1-philipp.psurek@gmail.com> (raw)
In-Reply-To: <4393196.oYPnlPzS5o@prime>
Am Dienstag, den 13.06.2017, 10:48 +0200 schrieb Simon Wunderlich:
> Hmm, I don't like this one too much, since it looks cryptic and we
> will have to add up new versions, which I'd like to avoid.
>
> Did you try to change the wording? I've googled a bit and it seems a
> comment containing the wording "fallthrough" will avoid it. Maybe we should
> just change "fall through" to "fallthrough"?
I also read about the wording but for some reason I do not want to change the
comment; because the many changes I tried were not recognized without a
compiler warning option in conjunction with the complete comment. The now
provided patch is recognized but the comment looks a little bit messed up. It
works if you don't mind the formatting of the code.
Thanks for the opportunity to contribute something to B.A.T.M.A.N.-Advanced.
Best regards,
Philipp
next prev parent reply other threads:[~2017-06-13 10:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 17:09 [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Philipp Psurek
2017-06-01 8:34 ` Simon Wunderlich
2017-06-03 2:14 ` Philipp Psurek
2017-06-03 3:12 ` [B.A.T.M.A.N.] [PATCH] batctl: suppress implicit-fallthrough compiler warning Philipp Psurek
2017-06-03 10:13 ` Philipp Psurek
2017-06-03 10:31 ` Philipp Psurek
2017-06-03 3:40 ` [B.A.T.M.A.N.] [PATCH] batctl: change PATH_BUFF_LEN to maximal possible value Philipp Psurek
2017-06-13 8:25 ` [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Philipp Psurek
2017-06-13 8:25 ` [B.A.T.M.A.N.] [PATCH 1/2] batctl: change PATH_BUFF_LEN to maximal possible value Philipp Psurek
2017-06-13 8:49 ` Simon Wunderlich
2017-06-13 8:26 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: suppress implicit-fallthrough compiler warning Philipp Psurek
2017-06-13 8:48 ` Simon Wunderlich
2017-06-13 10:39 ` Philipp Psurek [this message]
2017-06-13 10:39 ` [B.A.T.M.A.N.] [PATCH] " Philipp Psurek
2017-06-13 11:08 ` [B.A.T.M.A.N.] [PATCH 2/2] " Philipp Psurek
2017-06-13 11:08 ` [B.A.T.M.A.N.] [PATCH] " Philipp Psurek
2017-06-13 11:46 ` Simon Wunderlich
2017-06-13 11:53 ` Sven Eckelmann
2017-06-13 11:55 ` Sven Eckelmann
2017-06-13 12:25 ` Philipp Psurek
2017-06-13 8:42 ` [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613103916.27299-1-philipp.psurek@gmail.com \
--to=philipp.psurek@gmail.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox