From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH 00/10] batctl: Fixes and minor cleanup
Date: Thu, 23 Nov 2017 15:04:34 +0100 [thread overview]
Message-ID: <20171123140444.17119-1-sven.eckelmann@openmesh.com> (raw)
From: Sven Eckelmann <sven@narfation.org>
Hi,
today I had the unpleasent experience to receive [1] to a lot of PDF files
which seem to contain some reports of the Klocwork static code analysis tool.
Most of the stuff was nonsense about memory/resource leaks (even when it
stored in some kind of structure one line before). I gathered the only
interesting portions and prepared some patches for them.
The last two patches are actually not really bug fixes but are about code
which completely killed the static analyzer. I didn't like the code in
the last patch (looked to complex for something relatively easy) and thus
I've just replaced it.
WARNING: these things were only compile tested
Kind regards,
Sven
[1] not unpleasent due to some issue reports. But going through several
hundred false positives wasn't my goal for today. Someone at seems to
get paid by false-positives which this Klocworks analyzer produces
(and there are really some braindead ones - even clang's static analyzer
looks like a genius against some of these reports)
Sven Eckelmann (10):
batctl: Print dummy value when localtime failed
batctl: Handle failure during hash_iterator allocation
batctl: Handle allocation error for path_buff
batctl: Handle nlmsg_alloc errors
batctl: Handle nl_socket_alloc errors
batctl: Handle nl_cb_alloc errors
batctl: Free nl_sock on genl_ctrl_resolve error
batctl: Free nl_sock when if_nametoindex failed
batctl: tcpdump: Fix types for for TT v1
batctl: Simplify concatenation of pathnames
bat-hosts.c | 4 +---
functions.c | 8 ++------
hash.c | 3 +++
netlink.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++--------
sys.c | 15 +++++++++++++++
tcpdump.c | 9 +++++++--
6 files changed, 83 insertions(+), 19 deletions(-)
--
2.11.0
next reply other threads:[~2017-11-23 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 14:04 Sven Eckelmann [this message]
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 01/10] batctl: Print dummy value when localtime failed Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 02/10] batctl: Handle failure during hash_iterator allocation Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 03/10] batctl: Handle allocation error for path_buff Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 04/10] batctl: Handle nlmsg_alloc errors Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 05/10] batctl: Handle nl_socket_alloc errors Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 06/10] batctl: Handle nl_cb_alloc errors Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 07/10] batctl: Free nl_sock on genl_ctrl_resolve error Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 08/10] batctl: Free nl_sock when if_nametoindex failed Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 09/10] batctl: tcpdump: Fix types for for TT v1 Sven Eckelmann
2017-11-23 14:04 ` [B.A.T.M.A.N.] [PATCH 10/10] batctl: Simplify concatenation of pathnames Sven Eckelmann
2017-12-01 11:19 ` [B.A.T.M.A.N.] [PATCH 00/10] batctl: Fixes and minor cleanup Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123140444.17119-1-sven.eckelmann@openmesh.com \
--to=sven.eckelmann@openmesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox