From: kernel test robot <lkp@intel.com>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>,
"Johannes Berg" <johannes@sipsolutions.net>
Cc: kbuild-all@lists.01.org, linux-wireless@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org,
"Linus Lüssing" <ll@simonwunderlich.de>,
"Sven Eckelmann" <sven@narfation.org>,
"Simon Wunderlich" <sw@simonwunderlich.de>
Subject: Re: [PATCH v2] mac80211: mesh: add mesh_param "mesh_nolearn" to skip path discovery
Date: Wed, 17 Jun 2020 05:23:09 +0800 [thread overview]
Message-ID: <202006170505.S4o29uV7%lkp@intel.com> (raw)
In-Reply-To: <20200616103911.20501-1-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 8099 bytes --]
Hi "Linus,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mac80211-next/master]
[also build test ERROR on mac80211/master v5.8-rc1 next-20200616]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Linus-L-ssing/mac80211-mesh-add-mesh_param-mesh_nolearn-to-skip-path-discovery/20200616-183953
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: i386-debian-10.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
net/wireless/nl80211.c: In function 'nl80211_parse_mesh_config':
>> net/wireless/nl80211.c:7101:25: error: macro "FILL_IN_MESH_PARAM_IF_SET" passed 8 arguments, but takes just 6
7101 | nl80211_check_bool);
| ^
net/wireless/nl80211.c:6972: note: macro "FILL_IN_MESH_PARAM_IF_SET" defined here
6972 | #define FILL_IN_MESH_PARAM_IF_SET(tb, cfg, param, mask, attr, fn) |
>> net/wireless/nl80211.c:7099:2: error: 'FILL_IN_MESH_PARAM_IF_SET' undeclared (first use in this function)
7099 | FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshNolearn, 0, 1,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
net/wireless/nl80211.c:7099:2: note: each undeclared identifier is reported only once for each function it appears in
vim +/FILL_IN_MESH_PARAM_IF_SET +7101 net/wireless/nl80211.c
6979
6980 if (!info->attrs[NL80211_ATTR_MESH_CONFIG])
6981 return -EINVAL;
6982 if (nla_parse_nested_deprecated(tb, NL80211_MESHCONF_ATTR_MAX, info->attrs[NL80211_ATTR_MESH_CONFIG], nl80211_meshconf_params_policy, info->extack))
6983 return -EINVAL;
6984
6985 /* This makes sure that there aren't more than 32 mesh config
6986 * parameters (otherwise our bitfield scheme would not work.) */
6987 BUILD_BUG_ON(NL80211_MESHCONF_ATTR_MAX > 32);
6988
6989 /* Fill in the params struct */
6990 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshRetryTimeout, mask,
6991 NL80211_MESHCONF_RETRY_TIMEOUT, nla_get_u16);
6992 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshConfirmTimeout, mask,
6993 NL80211_MESHCONF_CONFIRM_TIMEOUT,
6994 nla_get_u16);
6995 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHoldingTimeout, mask,
6996 NL80211_MESHCONF_HOLDING_TIMEOUT,
6997 nla_get_u16);
6998 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshMaxPeerLinks, mask,
6999 NL80211_MESHCONF_MAX_PEER_LINKS,
7000 nla_get_u16);
7001 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshMaxRetries, mask,
7002 NL80211_MESHCONF_MAX_RETRIES, nla_get_u8);
7003 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshTTL, mask,
7004 NL80211_MESHCONF_TTL, nla_get_u8);
7005 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, element_ttl, mask,
7006 NL80211_MESHCONF_ELEMENT_TTL, nla_get_u8);
7007 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, auto_open_plinks, mask,
7008 NL80211_MESHCONF_AUTO_OPEN_PLINKS,
7009 nla_get_u8);
7010 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshNbrOffsetMaxNeighbor,
7011 mask,
7012 NL80211_MESHCONF_SYNC_OFFSET_MAX_NEIGHBOR,
7013 nla_get_u32);
7014 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMPmaxPREQretries, mask,
7015 NL80211_MESHCONF_HWMP_MAX_PREQ_RETRIES,
7016 nla_get_u8);
7017 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, path_refresh_time, mask,
7018 NL80211_MESHCONF_PATH_REFRESH_TIME,
7019 nla_get_u32);
7020 if (mask & BIT(NL80211_MESHCONF_PATH_REFRESH_TIME) &&
7021 (cfg->path_refresh_time < 1 || cfg->path_refresh_time > 65535))
7022 return -EINVAL;
7023 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, min_discovery_timeout, mask,
7024 NL80211_MESHCONF_MIN_DISCOVERY_TIMEOUT,
7025 nla_get_u16);
7026 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMPactivePathTimeout,
7027 mask,
7028 NL80211_MESHCONF_HWMP_ACTIVE_PATH_TIMEOUT,
7029 nla_get_u32);
7030 if (mask & BIT(NL80211_MESHCONF_HWMP_ACTIVE_PATH_TIMEOUT) &&
7031 (cfg->dot11MeshHWMPactivePathTimeout < 1 ||
7032 cfg->dot11MeshHWMPactivePathTimeout > 65535))
7033 return -EINVAL;
7034 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMPpreqMinInterval, mask,
7035 NL80211_MESHCONF_HWMP_PREQ_MIN_INTERVAL,
7036 nla_get_u16);
7037 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMPperrMinInterval, mask,
7038 NL80211_MESHCONF_HWMP_PERR_MIN_INTERVAL,
7039 nla_get_u16);
7040 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
7041 dot11MeshHWMPnetDiameterTraversalTime, mask,
7042 NL80211_MESHCONF_HWMP_NET_DIAM_TRVS_TIME,
7043 nla_get_u16);
7044 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMPRootMode, mask,
7045 NL80211_MESHCONF_HWMP_ROOTMODE, nla_get_u8);
7046 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMPRannInterval, mask,
7047 NL80211_MESHCONF_HWMP_RANN_INTERVAL,
7048 nla_get_u16);
7049 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshGateAnnouncementProtocol,
7050 mask, NL80211_MESHCONF_GATE_ANNOUNCEMENTS,
7051 nla_get_u8);
7052 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshForwarding, mask,
7053 NL80211_MESHCONF_FORWARDING, nla_get_u8);
7054 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, rssi_threshold, mask,
7055 NL80211_MESHCONF_RSSI_THRESHOLD,
7056 nla_get_s32);
7057 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshConnectedToMeshGate, mask,
7058 NL80211_MESHCONF_CONNECTED_TO_GATE,
7059 nla_get_u8);
7060 /*
7061 * Check HT operation mode based on
7062 * IEEE 802.11-2016 9.4.2.57 HT Operation element.
7063 */
7064 if (tb[NL80211_MESHCONF_HT_OPMODE]) {
7065 ht_opmode = nla_get_u16(tb[NL80211_MESHCONF_HT_OPMODE]);
7066
7067 if (ht_opmode & ~(IEEE80211_HT_OP_MODE_PROTECTION |
7068 IEEE80211_HT_OP_MODE_NON_GF_STA_PRSNT |
7069 IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT))
7070 return -EINVAL;
7071
7072 /* NON_HT_STA bit is reserved, but some programs set it */
7073 ht_opmode &= ~IEEE80211_HT_OP_MODE_NON_HT_STA_PRSNT;
7074
7075 cfg->ht_opmode = ht_opmode;
7076 mask |= (1 << (NL80211_MESHCONF_HT_OPMODE - 1));
7077 }
7078 FILL_IN_MESH_PARAM_IF_SET(tb, cfg,
7079 dot11MeshHWMPactivePathToRootTimeout, mask,
7080 NL80211_MESHCONF_HWMP_PATH_TO_ROOT_TIMEOUT,
7081 nla_get_u32);
7082 if (mask & BIT(NL80211_MESHCONF_HWMP_PATH_TO_ROOT_TIMEOUT) &&
7083 (cfg->dot11MeshHWMPactivePathToRootTimeout < 1 ||
7084 cfg->dot11MeshHWMPactivePathToRootTimeout > 65535))
7085 return -EINVAL;
7086 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMProotInterval, mask,
7087 NL80211_MESHCONF_HWMP_ROOT_INTERVAL,
7088 nla_get_u16);
7089 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshHWMPconfirmationInterval,
7090 mask,
7091 NL80211_MESHCONF_HWMP_CONFIRMATION_INTERVAL,
7092 nla_get_u16);
7093 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, power_mode, mask,
7094 NL80211_MESHCONF_POWER_MODE, nla_get_u32);
7095 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshAwakeWindowDuration, mask,
7096 NL80211_MESHCONF_AWAKE_WINDOW, nla_get_u16);
7097 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, plink_timeout, mask,
7098 NL80211_MESHCONF_PLINK_TIMEOUT, nla_get_u32);
> 7099 FILL_IN_MESH_PARAM_IF_SET(tb, cfg, dot11MeshNolearn, 0, 1,
7100 mask, NL80211_MESHCONF_NOLEARN,
> 7101 nl80211_check_bool);
7102 if (mask_out)
7103 *mask_out = mask;
7104
7105 return 0;
7106
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34627 bytes --]
next prev parent reply other threads:[~2020-06-16 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 10:39 [PATCH v2] mac80211: mesh: add mesh_param "mesh_nolearn" to skip path discovery Linus Lüssing
2020-06-16 10:39 ` [PATCH v2] iw: " Linus Lüssing
2020-06-16 17:41 ` [PATCH v2] mac80211: " kernel test robot
2020-06-16 21:23 ` kernel test robot [this message]
2020-06-17 13:27 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006170505.S4o29uV7%lkp@intel.com \
--to=lkp@intel.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=johannes@sipsolutions.net \
--cc=kbuild-all@lists.01.org \
--cc=linus.luessing@c0d3.blue \
--cc=linux-wireless@vger.kernel.org \
--cc=ll@simonwunderlich.de \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox