From: Simon Wunderlich <sw@simonwunderlich.de>
To: kuba@kernel.org, davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org
Subject: [PATCH 3/7] batman-adv: Avoid magic value for minimum MTU
Date: Wed, 16 Aug 2023 18:39:56 +0200 [thread overview]
Message-ID: <20230816164000.190884-4-sw@simonwunderlich.de> (raw)
In-Reply-To: <20230816164000.190884-1-sw@simonwunderlich.de>
From: Sven Eckelmann <sven@narfation.org>
The header linux/if_ether.h already defines a constant for the minimum MTU.
So simply use it instead of having a magic constant in the code.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
net/batman-adv/soft-interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index d3fdf82282af..f7947fad06f2 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -154,7 +154,7 @@ static int batadv_interface_set_mac_addr(struct net_device *dev, void *p)
static int batadv_interface_change_mtu(struct net_device *dev, int new_mtu)
{
/* check ranges */
- if (new_mtu < 68 || new_mtu > batadv_hardif_min_mtu(dev))
+ if (new_mtu < ETH_MIN_MTU || new_mtu > batadv_hardif_min_mtu(dev))
return -EINVAL;
dev->mtu = new_mtu;
--
2.39.2
next prev parent reply other threads:[~2023-08-16 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 16:39 [PATCH 0/7] pull request for net-next: batman-adv 2023-08-16 Simon Wunderlich
2023-08-16 16:39 ` [PATCH 1/7] batman-adv: Start new development cycle Simon Wunderlich
2023-08-18 22:20 ` patchwork-bot+netdevbpf
2023-08-16 16:39 ` [PATCH 2/7] batman-adv: Remove unused declarations Simon Wunderlich
2023-08-16 16:39 ` Simon Wunderlich [this message]
2023-08-16 16:39 ` [PATCH 4/7] batman-adv: Check hardif MTU against runtime MTU Simon Wunderlich
2023-08-16 16:39 ` [PATCH 5/7] batman-adv: Drop unused function batadv_gw_bandwidth_set Simon Wunderlich
2023-08-16 16:39 ` [PATCH 6/7] batman-adv: Keep batadv_netlink_notify_* static Simon Wunderlich
2023-08-16 16:40 ` [PATCH 7/7] batman-adv: Drop per algo GW section class code Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816164000.190884-4-sw@simonwunderlich.de \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox