From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [PATCH v5 0/3] batman-adv: add dynamic, bridged-in TT VID detection
Date: Sat, 1 Feb 2025 05:31:27 +0100 [thread overview]
Message-ID: <20250201043725.15217-1-linus.luessing@c0d3.blue> (raw)
For one thing the following patchest is supposed to mitigate the
regression of extra OGM overhead that we accidentally introduced with
the introduction of the compatibility version 15, the TVLV support it
provided, together with TT VLAN support. The addition of these TVLVs
roughly doubled the OGM overhead back then, also/mainly because the
8021q and Linux bridge modules would add TT VLAN IDs 0 and 1, even if
no one is actually using them. While the 8021q VLAN 0 ID addition was
addressed in upstream already, PATCH 3/3 tries to avoid unnecessary
VLAN additions from the bridge and only adds such VLANs if they were
detected on actual traffic.
In preparation of this the internal VLAN creation was overhauled in
PATCH 1/3. This also in theory allows detecting new VLAN IDs dynamically
from traffic from bridged-in traffic. So far, VLAN IDs could only be
used which were anticipated and configured on top of bat0 by the
administrator.
However the detection of VLANs from bridged-in clients is by default
disabled for now through PATCH 2/3. This patch adds a configurable limit
for such snooped VLAN IDs, defaulting to zero for now. The issue is that
each added VLAN still increases the OGM size considerably in the current
protocol, so it is not advised to add many VLANs at the moment, without
a bigger upgrade of the protocol. Also there is still an outstanding
issue with temporarily broken broadcast traffic upon adding a new VLAN if
BLA is enabled at the same time. Therefore defaulting to zero snooped
VLANs from bridged-in clients for now.
Regards, Linus
---
v5:
* rebased to current main branch:
-> PATCH 3/3 needed to readd the include for soft-interface.h for
batadv_softif_get_bridge() since commit
"50eddf397ac3 batman-adv: netlink: reduce duplicate code by returning interfaces"
v4:
* reworking PATCH 3/3:
* removing the added exception for VID 0 again, addressed upstream now
* replacing the specific VID 1 exception for the bridge default PVID
with a more generic solution: a user might change the PVID or add
other, untagged VLANs on an access port which we should also ignore;
instead always avoid such kernel event additions if a bridge is on
top of bat0
v3:
* fixing refcounting, removing an unnecessary kref_get() in PATCH 1/3
* adding PATCH 2/3 + PATCH 3/3
* resubmitting without the RFC tag
v2: fix a typo, a missing "to" in the commit message
next reply other threads:[~2025-02-01 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 4:31 Linus Lüssing [this message]
2025-02-01 4:31 ` [PATCH v5 1/3] batman-adv: add dynamic, bridged-in TT VID detection support Linus Lüssing
2025-02-01 4:31 ` [PATCH v5 2/3] batman-adv: limit number of learned VLANs from bridged-in clients Linus Lüssing
2025-02-01 4:31 ` [PATCH v5 3/3] batman-adv: avoid adding bridge VLAN IDs through ndo_vlan_rx_add_vid() Linus Lüssing
2025-02-01 9:42 ` [PATCH v5 0/3] batman-adv: add dynamic, bridged-in TT VID detection Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250201043725.15217-1-linus.luessing@c0d3.blue \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).