From: Jakub Kicinski <kuba@kernel.org>
To: David Lee <david.lee@trailofbits.com>
Cc: marek.lindner@mailbox.org, sw@simonwunderlich.de,
antonio@mandelbit.com, sven@narfation.org,
Kyle Zeng <kylebot@openai.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org,
Dominik 'Disconnect3d' Czarnota
<dominik.czarnota@trailofbits.com>,
netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v2] batman-adv: reject unrepresentable multicast TVLV offsets
Date: Tue, 11 Aug 2026 14:56:47 -0700 [thread overview]
Message-ID: <20260811145647.34a190e5@kernel.org> (raw)
In-Reply-To: <20260810145754.828936-1-david.lee@trailofbits.com>
On Mon, 10 Aug 2026 14:57:51 +0000 David Lee wrote:
> + long transport_offset = skb->data - skb->head + offset;
> +
> + if (unlikely(transport_offset !=
> + (typeof(skb->transport_header))transport_offset))
> + return false;
> +
> + if (unlikely(transport_offset ==
> + (typeof(skb->transport_header))~0U))
> + return false;
> +
> + skb->transport_header = transport_offset;
> + return true;
Find a better name for the variable instead of wrapping the lines.
prev parent reply other threads:[~2026-08-11 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 14:57 [PATCH net v2] batman-adv: reject unrepresentable multicast TVLV offsets David Lee
2026-08-11 15:32 ` Sven Eckelmann
2026-08-11 21:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811145647.34a190e5@kernel.org \
--to=kuba@kernel.org \
--cc=antonio@mandelbit.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=david.lee@trailofbits.com \
--cc=dominik.czarnota@trailofbits.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kylebot@openai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.lindner@mailbox.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox