* [B.A.T.M.A.N.] [PATCH] batman-adv: Fix variable declaration warning in batadv_compare_tt
@ 2015-11-18 8:41 Sven Eckelmann
2015-11-18 8:43 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2015-11-18 8:41 UTC (permalink / raw)
To: b.a.t.m.a.n
checkpatch is warning about the wrong way a pointer is declared in
batadv_compare_tt.
ERROR: "foo* bar" should be "foo *bar"
#80: FILE: ./net/batman-adv/translation-table.c:80:
+ const struct batadv_tt_common_entry* tt1 = data1;
Fixes: af5fa950cbb6 ("batman-adv: fix erroneous client entry duplicate detection")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
net/batman-adv/translation-table.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index 92af58b..c02f68e 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -77,8 +77,8 @@ static int batadv_compare_tt(const struct hlist_node *node, const void *data2)
{
const void *data1 = container_of(node, struct batadv_tt_common_entry,
hash_entry);
- const struct batadv_tt_common_entry* tt1 = data1;
- const struct batadv_tt_common_entry* tt2 = data2;
+ const struct batadv_tt_common_entry *tt1 = data1;
+ const struct batadv_tt_common_entry *tt2 = data2;
return (tt1->vid == tt2->vid) && batadv_compare_eth(data1, data2);
}
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix variable declaration warning in batadv_compare_tt
2015-11-18 8:41 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix variable declaration warning in batadv_compare_tt Sven Eckelmann
@ 2015-11-18 8:43 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2015-11-18 8:43 UTC (permalink / raw)
To: b.a.t.m.a.n
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Wednesday, November 18, 2015 09:41:41 Sven Eckelmann wrote:
> checkpatch is warning about the wrong way a pointer is declared in
> batadv_compare_tt.
>
> ERROR: "foo* bar" should be "foo *bar"
> #80: FILE: ./net/batman-adv/translation-table.c:80:
> + const struct batadv_tt_common_entry* tt1 = data1;
>
> Fixes: af5fa950cbb6 ("batman-adv: fix erroneous client entry duplicate
> detection") Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> net/batman-adv/translation-table.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Good point! Applied in revision 5019fc0.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-18 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-18 8:41 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix variable declaration warning in batadv_compare_tt Sven Eckelmann
2015-11-18 8:43 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox