Re: [B.A.T.M.A.N.] No rebroadcast on mesh links

Adrian Reyer
2016-03-29T17:59:57Z

[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]

On Tue, Mar 29, 2016 at 11:50:47AM +0200, Sven Eckelmann wrote:
> We still need at least one person interested in this patch who rebases the
> patch and resubmit its with a convincing commit message.

Well, I am a system administrator, no kernel developer. I have limited
knowledg about C and verious version control systems. If noone else is
willing to do it, I can try.

> It would also be interesting if it should be a simple flag or some if
> exporting the num_bcasts via $something would be sufficient. Or if the
> num_bcasts should be split into num_bcasts_otherif and
> num_bcasts_sameif and then exported.

It is two different things, the num_bcasts in my understanding is about
how many times the originator sends out its packets to assume everyone
has received it.
The flag we talk about is about if anyone receiving that packet on an
interface has to send it out on that very interface at all, e.g. it is
about everyone reachable via that interface sees the same neighbours
(e.g. switch) or a different group (e.g. wlan adhoc)

> Just keep in mind that this "flag" may has to be kept there until the end
> of time. So if there is a need for a new setting then it should at least
> be discussed if this is done right and not that someone else needs to add
> additional things shortly after it reached the Linux kernel.

Well, someone *might* want to be able to adjust the num_bcasts. However,
this is a different thing and neither adressed in that patch, nor a
problem I think that needs to be addressed as it seems the automatism does
a reasonable decent job here.

Regards,
Adrian
--
LiHAS - Adrian Reyer - Hessenwiesenstraße 10 - D-70565 Stuttgart
Fon: +49 (7 11) 78 28 50 90 - Fax: +49 (7 11) 78 28 50 91
Mail: lihas@lihas.de - Web: http://lihas.de
Linux, Netzwerke, Consulting & Support - USt-ID: DE 227 816 626 Stuttgart

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 461 bytes --]