Re: [B.A.T.M.A.N.] [PATCH v2 0/2] batman-adv: netlink support for DAT and MCAST

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Sonntag, 11. März 2018 00:53:19 CET Linus Lüssing wrote:
> This patchset adds netlink support for dumping DAT cache and multicast
> flags tables.
> 
> Changes in v2:
> ==============
> 
> - Added missing includes, "#include <linux/netlink.h>" and
>   "#include <uapi/linux/batman_adv.h>", to distributed-arp-table.c
> - Added missing forward declaration for "struct netlink_callback" to
>   distributed-arp-table.h
> - Changed nla_put_u32() to nla_put_in_addr() for BATADV_ATTR_DC_ADDRESS,
>   removed the then obsolete ntohl() conversion
> - Added missing include, "#include <linux/netlink.h>", to multicast.c
> - Changed nla_put_u8() to nla_put_u32() for BATADV_ATTR_MCAST_FLAGS and
>   BATADV_ATTR_MCAST_FLAGS_PRIV to enhance extensibility

Thanks for the doing the requested changes.

@Antonio: Can you please check whether you are ok with the new netlink names 
and types.

> +       [BATADV_ATTR_DC_ADDRESS]        = { .type = NLA_U32 },
> +       [BATADV_ATTR_DC_HWADDRESS]      = { .len = ETH_ALEN },
> +       [BATADV_ATTR_DC_VID]            = { .type = NLA_U16 },

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]