Re: [PATCH batadv 2/4] batman-adv: tt: only update flags for TT events

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]

On Wednesday, 7 October 2026 12:29:46 CEST Sven Eckelmann wrote:
> -               if (announce)
> -                       __batadv_tt_local_event(bat_priv, common,
> -                                               common->flags);
> +               /* BATADV_TT_CLIENT_ROAM can still be set (see above) when a
> +                * client which roamed away was re-added. It must not be
> +                * announced with an ADD because the other nodes would then
> +                * handle it as still roaming.
> +                */
> +               if (announce) {
> +                       event_flags = common->flags & ~BATADV_TT_CLIENT_ROAM;
> +                       __batadv_tt_local_event(bat_priv, common, event_flags);
> +               }

Antonio, this is rather awkward. It is caused by basically the return in 
following code:

		if (common->flags & BATADV_TT_CLIENT_PENDING) {
			batadv_dbg(BATADV_DBG_TT, bat_priv,
				   "Re-adding pending client %pM (vid: %d)\n",
				   common->addr, batadv_print_vid(common->vid));
			/* whatever the reason why the PENDING flag was set,
			 * this is a client which was enqueued to be removed in
			 * this orig_interval. Since it popped up again, the
			 * flag can be reset like it was never enqueued
			 */
			common->flags &= ~BATADV_TT_CLIENT_PENDING;

			return true;
		}

		if (common->flags & BATADV_TT_CLIENT_ROAM) {
			batadv_dbg(BATADV_DBG_TT, bat_priv,
				   "Roaming client %pM (vid: %d) came back to its original location\n",
				   common->addr, batadv_print_vid(common->vid));
			/* the ROAM flag is set because this client roamed away
			 * and the node got a roaming_advertisement message. Now
			 * that the client popped up again at its original
			 * location such flag can be unset
			 */
			common->flags &= ~BATADV_TT_CLIENT_ROAM;
			*roamed_back = true;
		}


I know, when you introduced the BATADV_TT_CLIENT_ROAM check in commit 
2443ba383c7d ("batman-adv: roaming handling mechanism redesign"), it was still 
a `goto add_orig_entry;`. But the behavior was the same: two packets are 
necessary to switch a BATADV_TT_CLIENT_PENDING|BATADV_TT_CLIENT_ROAM client 
back to having none of the two flags.

Why is this the case?

Regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]