From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: suppress implicit-fallthrough compiler warning
Date: Tue, 13 Jun 2017 13:53:01 +0200 [thread overview]
Message-ID: <2063591.f2Dj0aj4GU@bentobox> (raw)
In-Reply-To: <2394098.zSA1hTeZKT@prime>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On Dienstag, 13. Juni 2017 13:46:04 CEST Simon Wunderlich wrote:
[...]
> I've adopted your patch, but put the second part of the comment into the
> following case to avoid the ugliness. I didn't test with gcc 7.1 but hope that
> should work. Please check here:
>
> https://git.open-mesh.org/batctl.git/blobdiff/
> 620226bf8cff30e6dd966c8fe922b2d4cddf843b..
> 50ee3c45feeda6d8c04ee127097badf99f78a26e:/tp_meter.c
The other option would have been to change it to:
/* fall through - print the partial result */
At least the documentation allows non-escape chars after the "fall through"
marker when a "-" was added between them. I've removed the "and" in this
example because it looked weird.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-13 11:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 17:09 [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Philipp Psurek
2017-06-01 8:34 ` Simon Wunderlich
2017-06-03 2:14 ` Philipp Psurek
2017-06-03 3:12 ` [B.A.T.M.A.N.] [PATCH] batctl: suppress implicit-fallthrough compiler warning Philipp Psurek
2017-06-03 10:13 ` Philipp Psurek
2017-06-03 10:31 ` Philipp Psurek
2017-06-03 3:40 ` [B.A.T.M.A.N.] [PATCH] batctl: change PATH_BUFF_LEN to maximal possible value Philipp Psurek
2017-06-13 8:25 ` [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Philipp Psurek
2017-06-13 8:25 ` [B.A.T.M.A.N.] [PATCH 1/2] batctl: change PATH_BUFF_LEN to maximal possible value Philipp Psurek
2017-06-13 8:49 ` Simon Wunderlich
2017-06-13 8:26 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: suppress implicit-fallthrough compiler warning Philipp Psurek
2017-06-13 8:48 ` Simon Wunderlich
2017-06-13 10:39 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: suppress implicit-fallthrough compiler Philipp Psurek
2017-06-13 10:39 ` [B.A.T.M.A.N.] [PATCH] batctl: suppress implicit-fallthrough compiler warning Philipp Psurek
2017-06-13 11:08 ` [B.A.T.M.A.N.] [PATCH 2/2] " Philipp Psurek
2017-06-13 11:08 ` [B.A.T.M.A.N.] [PATCH] " Philipp Psurek
2017-06-13 11:46 ` Simon Wunderlich
2017-06-13 11:53 ` Sven Eckelmann [this message]
2017-06-13 11:55 ` Sven Eckelmann
2017-06-13 12:25 ` Philipp Psurek
2017-06-13 8:42 ` [B.A.T.M.A.N.] [batctl] compiling with gcc 7.1.0: there are some notes and warnings Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2063591.f2Dj0aj4GU@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox