From: Sven Eckelmann <sven@narfation.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Antonio Quartulli <a@unstable.cc>,
davem@davemloft.net, Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Reduce refcnt of removed router when updating route
Date: Tue, 26 Apr 2016 17:00:28 +0200 [thread overview]
Message-ID: <2064019.8u38J1EmDF@bentobox> (raw)
In-Reply-To: <83cedcb0-1090-2a0d-f3b8-c9c273c5f1d2@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]
On Tuesday 26 April 2016 17:42:54 Sergei Shtylyov wrote:
> > _batadv_update_route rcu_derefences orig_ifinfo->router outside of a
> > spinlock protected region to print some information messages to the debug
> > log. But this pointer is not checked again when the new pointer is assigned
> > in the spinlock protected region. Thus is can happen that the value of
>
> Thus is can? :-)
Yes, my fault. s/is/it/.
[...]
> > spin_lock_bh(&orig_node->neigh_list_lock);
> > + /* curr_router used earlier may not be the current orig_ifinfo->router
> > + * anymore because it was dereferenced outside of the neigh_list_lock
> > + * protected region. After the new best neighbor has replace the current
>
> Replaced.
>
> [...]
This one looks like one of Marek's modifications [1] to the patch. But I would
guess that he has nothing against adding a 'd'.
Should Antonio resent all the patches or is a different approach preferred?
Kind regards,
Sven
[1] https://patchwork.open-mesh.org/patch/15940/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-26 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 3:27 [B.A.T.M.A.N.] pull request [net]: batman-adv-0160426 Antonio Quartulli
2016-04-26 3:27 ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Check skb size before using encapsulated ETH+VLAN header Antonio Quartulli
2016-04-26 3:27 ` [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: init neigh node last seen field Antonio Quartulli
2016-04-26 3:27 ` [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Deactivate TO_BE_ACTIVATED hardif on shutdown Antonio Quartulli
2016-04-26 3:27 ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Reduce refcnt of removed router when updating route Antonio Quartulli
2016-04-26 14:42 ` Sergei Shtylyov
2016-04-26 15:00 ` Sven Eckelmann [this message]
2016-04-26 3:27 ` [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Fix broadcast/ogm queue limit on a removed interface Antonio Quartulli
2016-04-28 20:43 ` [B.A.T.M.A.N.] pull request [net]: batman-adv-0160426 David Miller
2016-04-28 23:58 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2064019.8u38J1EmDF@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox