Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Increase purge timeout on DAT DHT candidates

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

Hi,

> > With this patch the purge timeout for local DAT cache entries and
> > entries submitted via a DHT_PUT message is differentiated:
> > 
> > While the former stays at 5min. the latter is increased to 30min. Which
> > decreases the rate of broadcasted ARP Requests.
> > 
> > Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> 
> @Marek, if I remember correctly, you had some issues [1] with this approach.
> Could you please check again

Sven, thanks for pointing this out. Antonio and I had to refresh our memories 
on these matters since the previously rejected patch had aged 6 months by now.

The conclusion is this:
* The old patch was rejected because it was tied to IP/MAC address 
combinations snooped via DHCP only (!). The magic happens inside 
batadv_dat_put_pairs() which was called via the DHCP snooping path. When 
comparing the old and new patch be careful as batadv_dat_put_pairs() has been 
renamed to batadv_dat_put_dhcp(). 
With the new patch that DHCP dependency is no longer present. The way to go!
* The old patch also introduced flags being sent around which wasn't all that 
necessary. This is also gone -> green light++

I'll comment on the patch itself for further simplifications.

Cheers,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]