From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: Snoop DHCPACKs for DAT
Date: Sun, 10 Jul 2016 13:42:32 +0200 [thread overview]
Message-ID: <2069472.CH1chEaXG0@sven-edge> (raw)
In-Reply-To: <1467741697-8811-2-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On Dienstag, 5. Juli 2016 20:01:37 CEST Linus Lüssing wrote:
> /**
> + * batadv_dat_check_dhcp_ipudp - check skb for IP+UDP headers valid for
> DHCP + * @skb: the packet to check
> + * @proto: ethernet protocol hint (behind a potential vlan)
> + *
> + * Checks whether the given skb has an IP and UDP header valid for a DHCP
> + * message from a DHCP server.
> + *
> + * Return: True if valid, false otherwise.
> + */
> +static bool batadv_dat_check_dhcp_ipudp(struct sk_buff *skb)
> +{
Looks like this function doesn't have the parameter proto which you've
described in the kerneldoc.
It sounds like the patch didn't help. So I will postpone my review.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-10 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 18:01 [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: Add wrapper for ARP reply creation Linus Lüssing
2016-07-05 18:01 ` [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: Snoop DHCPACKs for DAT Linus Lüssing
2016-07-07 9:24 ` Antonio Quartulli
2016-07-07 9:43 ` Sven Eckelmann
2016-07-07 10:14 ` Linus Lüssing
2016-07-07 13:40 ` Linus Lüssing
2016-07-08 0:33 ` Antonio Quartulli
2016-07-10 11:42 ` Sven Eckelmann [this message]
2016-08-23 1:31 ` Linus Lüssing
2016-07-10 11:18 ` [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: Add wrapper for ARP reply creation Sven Eckelmann
2016-10-18 13:01 ` [B.A.T.M.A.N.] [v2, " Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2069472.CH1chEaXG0@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox