From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix kernel crash due to missing NULL checks
Date: Fri, 19 Jun 2015 13:50:45 +0800 [thread overview]
Message-ID: <2071356.udBP3C0Di5@voltaire> (raw)
In-Reply-To: <55831C89.9030707@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On Thursday, June 18, 2015 21:31:21 Antonio Quartulli wrote:
> WARN returns the value of the expression passed as first argument,
> therefore you can directly pass "!vlan" and use the whole macro
> invocation as if condition.
I am aware of this 'feature' but I don't find it readable enough. In the Linux
kernel I found several code sections using the proposed style too which made
me favor it. Do you insist on changing that ?
> Note: if you are going to merge this patch before Sven's one you need to
> also include bug.h.
Ok.
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-06-19 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 3:04 [B.A.T.M.A.N.] [PATCHv2 maint] batman-adv: fix kernel crash due to missing NULL checks Marek Lindner
2015-06-18 19:31 ` Antonio Quartulli
2015-06-19 5:50 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2071356.udBP3C0Di5@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox