Re: [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

Sven Eckelmann
2018-05-20T04:37:21Z

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

Hi Jiri,

seems like you still haven't answered Linus' question.

On Montag, 7. Mai 2018 08:34:16 CEST Sven Eckelmann wrote:
> On Dienstag, 27. März 2018 17:43:08 CEST Linus Lüssing wrote:
> > On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote:
> > > >> I strongly believe it is a huge mistake to use sysfs for things like
> > > >> this. This should be done via generic netlink api.
> > > >
> > > >This doesn't change the problem that it is already that way. This patch
> > > >only adds the list of available files to the README.
> > >
> > > Sure. Just found out you did it like that. Therefore I commented. I
> > > suggest to rework the api to use genl entirely.
> >
> > Hi Jiri,
> >
> > Thanks for sharing your thoughts!
> >
> > Could you explain a bit more on which disadvantages you see in
> > the usage of sysfs here?
>
> Linus is asking because of following patch:
> https://patchwork.open-mesh.org/patch/17340/

The next patch with a similar problem would be
https://patchwork.open-mesh.org/patch/17372/. It is rather important that you
are discussing this with Linus Luessing and Marek Lindner.

Kind regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]