Re: [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README

Jiri Pirko
2016-10-29T10:56:28Z

Sat, Oct 29, 2016 at 12:37:07PM CEST, sven@narfation.org wrote:
>On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote:
>[...]
>> >--- a/Documentation/networking/batman-adv.txt
>> >+++ b/Documentation/networking/batman-adv.txt
>> >@@ -71,10 +71,11 @@ All mesh wide settings can be found in batman's own interface
>> > folder:
>> >
>> > # ls /sys/class/net/bat0/mesh/
>> >-#aggregated_ogms distributed_arp_table gw_sel_class orig_interval
>> >-#ap_isolation fragmentation hop_penalty routing_algo
>> >-#bonding gw_bandwidth isolation_mark vlan0
>> >-#bridge_loop_avoidance gw_mode log_level
>> >+# aggregated_ogms fragmentation isolation_mark routing_algo
>> >+# ap_isolation gw_bandwidth log_level vlan0
>> >+# bonding gw_mode multicast_mode
>> >+# bridge_loop_avoidance gw_sel_class network_coding
>> >+# distributed_arp_table hop_penalty orig_interval
>>
>> I strongly believe it is a huge mistake to use sysfs for things like
>> this. This should be done via generic netlink api.
>
>This doesn't change the problem that it is already that way. This patch
>only adds the list of available files to the README.

Sure. Just found out you did it like that. Therefore I commented. I
suggest to rework the api to use genl entirely.

>
>Kind regards,
> Sven