Re: [B.A.T.M.A.N.] [PATCH 17/17] batman-adv: Avoid precedence issues in macros

Sven Eckelmann
2016-10-28T21:27:31Z

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On Freitag, 28. Oktober 2016 14:13:06 CEST Joe Perches wrote:
> On Thu, 2016-10-27 at 21:01 +0200, Simon Wunderlich wrote:
> > From: Sven Eckelmann <sven@narfation.org>
> >
> > It must be avoided that arguments to a macro are evaluated ungrouped (which
> > enforces normal operator precendence). Otherwise the result of the macro
> > is not well defined.
>
> Curiosity:
>
> in net/batman-adv/tp_meter.c
[...]
> orig_node = batadv_orig_hash_find(bat_priv, tp_vars->other_end);
> if (unlikely(!orig_node)) {
> err = BATADV_TP_REASON_DST_UNREACHABLE;
> tp_vars->reason = err;
> goto out;
> }
>
> primary_if = batadv_primary_if_get_selected(bat_priv);
> if (unlikely(!primary_if)) {
> err = BATADV_TP_REASON_DST_UNREACHABLE;
> goto out;
> }
>
> err is not used in the out block
>
> Is the last if block supposed to set tp_vars->reason to err?

This seems to be unrelated to this patch.

But yes, looks to me like it is missing. Do you want to propose a patch or
should I do? Just make sure you Cc Antonio Quartulli <a@unstable.cc> (and of
course b.a.t.m.a.n@lists.open-mesh.org). He is the original author of
33a3bb4a3345 ("batman-adv: throughput meter implementation").

Kind regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]