From: Sven Eckelmann <sven.eckelmann@open-mesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Simon Wunderlich <simon.wunderlich@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix logic error in batadv_v_ogm_forward
Date: Mon, 15 Feb 2016 09:30:09 +0100 [thread overview]
Message-ID: <2083986.sQ3UmFvpA5@bentobox> (raw)
In-Reply-To: <1455273335-27063-1-git-send-email-sw@simonwunderlich.de>
On Friday 12 February 2016 11:35:35 Simon Wunderlich wrote:
> From: Simon Wunderlich <simon.wunderlich@open-mesh.com>
>
> My latest restructure attempt of the BATMAN v forward function
> introduced a regression, causing kernel crashes when an OGM is
> forwarded. This patch fixes it.
>
> Fixes: 30c96bc787 ("batman-adv: move and restructure
> batadv_v_ogm_forward")
> Reported-by: Sven Eckelmann <sven.eckelmann@open-mesh.com>
> Signed-off-by: Simon Wunderlich <simon.wunderlich@open-mesh.com>
Thanks for the fast update. It fixes the problem in my setup
Tested-by: Sven Eckelmann <sven.eckelmann@open-mesh.com>
> ---
> net/batman-adv/bat_v_ogm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c
> index 1b2399e..4155fa5 100644
> --- a/net/batman-adv/bat_v_ogm.c
> +++ b/net/batman-adv/bat_v_ogm.c
> @@ -309,7 +309,7 @@ static void batadv_v_ogm_forward(struct batadv_priv *bat_priv,
> u16 tvlv_len;
>
> /* only forward for specific interfaces, not for the default one. */
> - if (if_outgoing != BATADV_IF_DEFAULT)
> + if (if_outgoing == BATADV_IF_DEFAULT)
> goto out;
>
> orig_ifinfo = batadv_orig_ifinfo_new(orig_node, if_outgoing);
>
next prev parent reply other threads:[~2016-02-15 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 10:35 [B.A.T.M.A.N.] [PATCH] batman-adv: fix logic error in batadv_v_ogm_forward Simon Wunderlich
2016-02-15 8:30 ` Sven Eckelmann [this message]
2016-02-16 9:07 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2083986.sQ3UmFvpA5@bentobox \
--to=sven.eckelmann@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=simon.wunderlich@open-mesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox