From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>,
"Daniel Ehlers" <sargon@toppoint.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: allow snooping gratuitous ARP Replies
Date: Fri, 15 Feb 2019 00:16:31 +0800 [thread overview]
Message-ID: <2119814.DADNbvlFmJ@rousseau> (raw)
In-Reply-To: <20190214155100.10070-1-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
On Thursday, 14 February 2019 23:51:00 HKT Linus Lüssing wrote:
> So far, gratuitous ARP Replies were ignored for DAT processing as it
> contains a broadcast MAC address. This patch changes this and allows
> snooping such ARP messages, too.
> Gratuitous ARP Replies were ignored since this commit:
> ab361a9ccc5 ("batman-adv: filter ARP packets with invalid MAC addresses in
DAT")
You're kind enough to mention when the filter was introduced but fail to
explain why the filter introduced in the past was has outlived its usefulness
or how the new behavior addresses the previous concerns.
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-14 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 15:51 [B.A.T.M.A.N.] [PATCH] batman-adv: allow snooping gratuitous ARP Replies Linus Lüssing
2019-02-14 16:16 ` Marek Lindner [this message]
2019-02-14 17:49 ` Linus Lüssing
2019-02-15 6:36 ` Antonio Quartulli
2019-02-15 17:45 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2119814.DADNbvlFmJ@rousseau \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
--cc=sargon@toppoint.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox