From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Jiri Pirko <jiri@mellanox.com>, netdev@vger.kernel.org
Subject: Re: [B.A.T.M.A.N.] [RFC v2 11/19] batman-adv: Add gateway mesh genl configuration
Date: Sat, 24 Nov 2018 21:52:36 +0100 [thread overview]
Message-ID: <2150224.WNsGD1XmFl@sven-desktop> (raw)
In-Reply-To: <20181123161359.13342-12-sven@narfation.org>
On Freitag, 23. November 2018 17:13:51 CET Sven Eckelmann wrote:
> + /** @BATADV_GW_MODE_CLIENT: announce itself as gatway server */
> + BATADV_GW_MODE_SERVER,
The kernel-doc should actually be for BATADV_GW_MODE_SERVER.
[...]
> + if (sel_class < 1 || sel_class > sel_class_max) {
> + atomic_set(&bat_priv->gw.sel_class, sel_class);
> + batadv_gw_reselect(bat_priv);
> + }
Should have been:
if (sel_class >= 1 && sel_class <= sel_class_max) {
Kind regards,
Sven
next prev parent reply other threads:[~2018-11-24 20:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 16:13 [B.A.T.M.A.N.] [RFC v2 00/19] batman-adv: netlink restructuring, part 2 Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 01/19] batman-adv: Move common genl doit code pre/post hooks Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 02/19] batman-adv: Prepare framework for mesh genl config Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 03/19] batman-adv: Prepare framework for hardif " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 04/19] batman-adv: Prepare framework for vlan " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 05/19] batman-adv: Add aggregated_ogms mesh genl configuration Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 06/19] batman-adv: Add ap_isolation mesh/vlan " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 07/19] batman-adv: Add bonding mesh " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 08/19] batman-adv: Add bridge_loop_avoidance " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 09/19] batman-adv: Add distributed_arp_table " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 10/19] batman-adv: Add fragmentation " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 11/19] batman-adv: Add gateway " Sven Eckelmann
2018-11-24 20:52 ` Sven Eckelmann [this message]
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 12/19] batman-adv: Add hop_penalty " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 13/19] batman-adv: Add log_level " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 14/19] batman-adv: Add multicast_mode " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 15/19] batman-adv: Add network_coding " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 16/19] batman-adv: Add orig_interval " Sven Eckelmann
2018-11-24 17:52 ` Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 17/19] batman-adv: Add elp_interval hardif " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 18/19] batman-adv: Add throughput_override " Sven Eckelmann
2018-11-23 16:13 ` [B.A.T.M.A.N.] [RFC v2 19/19] batman-adv: Trigger genl notification on sysfs config change Sven Eckelmann
2018-11-24 9:29 ` [B.A.T.M.A.N.] [RFC v2 00/19] batman-adv: netlink restructuring, part 2 Jiri Pirko
2018-11-24 9:44 ` Sven Eckelmann
2018-11-24 10:23 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2150224.WNsGD1XmFl@sven-desktop \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox