Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use static string for table headers

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

On Thursday 07 November 2013 08:24:51 Antonio Quartulli wrote:
> Use a static string when showing table headers rather then
> a nonsense parametric one with fixed arguments.
> 
> It is easier to grep and it does not need to be recomputed
> at runtime each time.
> 
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
>  bat_iv_ogm.c            | 5 ++---
>  bridge_loop_avoidance.c | 7 +++----
>  distributed-arp-table.c | 4 ++--
>  translation-table.c     | 9 ++++-----
>  4 files changed, 11 insertions(+), 14 deletions(-)
> 

It looks that there now one more table in net/batman-adv/bat_iv_ogm.c and
two in net/batman-adv/bat_v.c

    $ git grep seq_printf|grep '%-'
    net/batman-adv/bat_iv_ogm.c:    seq_printf(seq, "  %-15s %s (%s/%i) %17s [%10s]: %20s ...\n",
    net/batman-adv/bat_iv_ogm.c:    seq_printf(seq, "   %10s        %-13s %s\n",
    net/batman-adv/bat_v.c: seq_printf(seq, "  %-15s %s (%11s) [%10s]\n", "Neighbor",
    net/batman-adv/bat_v.c: seq_printf(seq, "  %-15s %s (%11s) %17s [%10s]: %20s ...\n",
    net/batman-adv/bridge_loop_avoidance.c: seq_printf(seq, "   %-17s    %-5s    %-17s [o] (%-6s)\n",
    net/batman-adv/bridge_loop_avoidance.c: seq_printf(seq, "   %-17s    %-5s %-9s (%-6s)\n",
    net/batman-adv/distributed-arp-table.c: seq_printf(seq, "          %-7s          %-9s %4s %11s\n", "IPv4",
    net/batman-adv/translation-table.c:     seq_printf(seq, "       %-13s  %s %-8s %-9s (%-10s)\n", "Client", "VID",
    net/batman-adv/translation-table.c:     seq_printf(seq, "       %-13s  %s  %s       %-15s %s (%-10s) %s\n",

But I can update these parts myself and send a fresh version to the
mailing list.

Kind regards,
	Sve

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]