From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH-maint] batman-adv: fix potential orig_node reference leak
Date: Tue, 11 Feb 2014 20:04:45 +0800 [thread overview]
Message-ID: <2217082.vixKCQPpGW@diderot> (raw)
In-Reply-To: <1391874306-15627-1-git-send-email-sw@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On Saturday 08 February 2014 16:45:06 Simon Wunderlich wrote:
> Since batadv_orig_node_new() sets the refcount to two, assuming that
> the calling function will use a reference for putting the orig_node into
> a hash or similar, both references must be freed if initialization of
> the orig_node fails. Otherwise that object may be leaked in that error
> case.
>
> Reported-by: Antonio Quartulli <antonio@meshcoding.com>
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
> ---
> bat_iv_ogm.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied in revision cb4d66e.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2014-02-11 12:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 15:45 [B.A.T.M.A.N.] [PATCH-maint] batman-adv: fix potential orig_node reference leak Simon Wunderlich
2014-02-11 12:04 ` Marek Lindner [this message]
2014-02-11 17:26 ` Antonio Quartulli
2014-02-11 17:29 ` Martin Hundebøll
2014-02-11 17:34 ` Antonio Quartulli
2014-02-11 17:40 ` Marek Lindner
2014-02-11 17:45 ` Antonio Quartulli
2014-02-11 17:35 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2217082.vixKCQPpGW@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox