From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv6 1/2] batman-adv: use vlan_/eth_hdr() instead of skb->data in interface_tx path
Date: Mon, 27 Jan 2014 15:38:12 +0800 [thread overview]
Message-ID: <2269233.xVshGbV36T@diderot> (raw)
In-Reply-To: <1390166566-8315-2-git-send-email-linus.luessing@web.de>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Sunday 19 January 2014 22:22:45 Linus Lüssing wrote:
> Our .ndo_start_xmit handler (batadv_interface_tx()) can rely on having
> the skb mac header pointer set correctly since the following commit
> present in kernels >= 3.9:
>
> "net: reset mac header in dev_start_xmit()" (6d1ccff627)
>
> Therefore we can safely use eth_hdr() and vlan_eth_hdr() instead of
> skb->data now, which spares us some ugly type casts.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
> ---
> bridge_loop_avoidance.c | 2 +-
> compat.h | 11 +++++++++++
> gateway_client.c | 6 +++---
> send.c | 2 +-
> soft-interface.c | 8 ++++----
> 5 files changed, 20 insertions(+), 9 deletions(-)
Applied in revision f9170f2.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2014-01-27 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 21:22 [B.A.T.M.A.N.] [PATCH v6 0/2] eth_hdr/skb_reset_mac_header changes Linus Lüssing
2014-01-19 21:22 ` [B.A.T.M.A.N.] [PATCHv6 1/2] batman-adv: use vlan_/eth_hdr() instead of skb->data in interface_tx path Linus Lüssing
2014-01-27 7:38 ` Marek Lindner [this message]
2014-01-19 21:22 ` [B.A.T.M.A.N.] [PATCHv6 2/2] batman-adv: remove obsolete skb_reset_mac_header() in batadv_bla_tx() Linus Lüssing
2014-01-27 7:39 ` Marek Lindner
2014-01-19 22:58 ` [B.A.T.M.A.N.] [PATCH v6 0/2] eth_hdr/skb_reset_mac_header changes Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2269233.xVshGbV36T@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox