Re: [B.A.T.M.A.N.] [Patchv2 0/7] batman-adv: Optimizations for setups running dat and bla

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1.1: Type: text/plain, Size: 5113 bytes --]

=2D-nextPart5558910.ktjs2kg59P
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Friday 26 February 2016 14:16:38 Andreas Pape wrote:
> This patchset introduces optimizations for batman-adv in setups having
> several gateways into a common (switched) Ethernet backbone network
> especially if dat is additionally enabled.
[...]

See my other comments directly to the patches. Please try to set the
in-reply-to of the patches to the message-id of the cover letter. Otherwise
the messages aren't correctly threaded on the mailinglist [1].

And you can set the version number of the patch directly using
git-format-patch:

    git format-patch -v 2 origin/master

I haven't done the complete build_test run but at least a quick test against 
4.4 only. The result is attached.

Kind regards,
	Sven


[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-February/thread.html

=2D-nextPart5558910.ktjs2kg59P
Content-Disposition: attachment; filename="build-test_andreas-pape_bla-fixes.mbox"
Content-Transfer-Encoding: 7Bit
Content-Type: application/mbox; name="build-test_andreas-pape_bla-fixes.mbox"

X-Original-To: sven
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: blabla Build check errors found: 2016-02-26
From: postmaster@open-mesh.org
Date: Fri, 26 Feb 2016 17:17:23 +0100 (CET)

Name of failed tests
====================

 * bracket_align blabla ./net/batman-adv/bridge_loop_avoidance.c
 * bracket_align blabla ./net/batman-adv/distributed-arp-table.c
 * bracket_align blabla ./net/batman-adv/soft-interface.c
 * checkpatch blabla ./net/batman-adv/bridge_loop_avoidance.c
 * smatch blabla linux-4.4 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=y
 * smatch blabla linux-4.4 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y
 * smatch blabla linux-4.4 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_BATMAN_V=n
 * smatch blabla linux-4.4 CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUG=n CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y
 * sparse blabla linux-4.4 cfg: BLA=n DAT=n DEBUG=n NC=y MCAST=y BATMAN_V=y
 * sparse blabla linux-4.4 cfg: BLA=n DAT=n DEBUG=y NC=n MCAST=n BATMAN_V=y
 * sparse blabla linux-4.4 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
 * sparse blabla linux-4.4 cfg: BLA=y DAT=n DEBUG=n NC=n MCAST=n BATMAN_V=y
 * unused_symbols blabla linux-4.4 cfg: BLA=y DAT=n DEBUG=n NC=n MCAST=n BATMAN_V=y

Output of different failed tests
================================

bracket_align blabla ./net/batman-adv/bridge_loop_avoidance.c
=2D------------------------------------------------------------

    Found wrong alignment at ./net/batman-adv/bridge_loop_avoidance.c:1661, was 33 but expected 37
    Found wrong alignment at ./net/batman-adv/bridge_loop_avoidance.c:1662, was 33 but expected 37


bracket_align blabla ./net/batman-adv/distributed-arp-table.c
=2D------------------------------------------------------------

    Found wrong alignment at ./net/batman-adv/distributed-arp-table.c:1126, was 30 but expected 29
    Found wrong alignment at ./net/batman-adv/distributed-arp-table.c:1128, was 30 but expected 29


bracket_align blabla ./net/batman-adv/soft-interface.c
=2D-----------------------------------------------------

    Found wrong alignment at ./net/batman-adv/soft-interface.c:434, was 49 but expected 58


checkpatch blabla ./net/batman-adv/bridge_loop_avoidance.c
=2D---------------------------------------------------------

    CHECK: Alignment should match open parenthesis
    #1661: FILE: ./net/batman-adv/bridge_loop_avoidance.c:1661:
    +		batadv_handle_claim(bat_priv, primary_if,
    +				primary_if->net_dev->dev_addr,
    
    total: 0 errors, 0 warnings, 1 checks, 1995 lines checked


smatch blabla linux-4.4 CONFIG_BATMAN_ADV_BLA=n CONFIG_BATMAN_ADV_DAT=n CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_NC=n CONFIG_BATMAN_ADV_MCAST=n CONFIG_BATMAN_ADV_BATMAN_V=y
=2D--------------------------------------------------------------------------

    net/batman-adv/routing.c:896 batadv_recv_unicast_packet warn: unused return: orig_node = batadv_orig_hash_find()
    net/batman-adv/soft-interface.c:433 batadv_interface_rx() warn: potential pointer math issue ('vhdr' is a 144 bit pointer)


sparse blabla linux-4.4 cfg: BLA=n DAT=n DEBUG=y NC=n MCAST=n BATMAN_V=y
=2D-----------------------------------------------------------------------

    net/batman-adv/soft-interface.c:432:33: warning: restricted __be16 degrades to integer


unused_symbols blabla linux-4.4 cfg: BLA=y DAT=n DEBUG=n NC=n MCAST=n BATMAN_V=y
=2D--------------------------------------------------------------------------

    batadv_bla_handle_local_claim


=2D-nextPart5558910.ktjs2kg59P--
This is a multi-part message in MIME format.

[-- Attachment #1.2: Type: text/plain, Size: 798 bytes --]

On Friday 26 February 2016 14:16:38 Andreas Pape wrote:
> This patchset introduces optimizations for batman-adv in setups having
> several gateways into a common (switched) Ethernet backbone network
> especially if dat is additionally enabled.
[...]

See my other comments directly to the patches. Please try to set the
in-reply-to of the patches to the message-id of the cover letter. Otherwise
the messages aren't correctly threaded on the mailinglist [1].

And you can set the version number of the patch directly using
git-format-patch:

    git format-patch -v 2 origin/master

I haven't done the complete build_test run but at least a quick test against 
4.4 only. The result is attached.

Kind regards,
	Sven


[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-February/thread.html

[-- Attachment #1.3: build-test_andreas-pape_bla-fixes.mbox --]
[-- Type: application/mbox, Size: 3887 bytes --]

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]