https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831135117.574836-1-sw%40simonwunderlich.de?part=1 > --- Patch [1]: [PATCH net-next 01/15] batman-adv: dat: fix printing of unknown 4addr subtype --- > commit 974c511b32b67ede89d952e4508493380b181449 > Author: Sven Eckelmann > > batman-adv: dat: fix printing of unknown 4addr subtype > > The default arm of the subtype switch in batadv_dbg_arp() was printing > unicast_4addr_packet->u.packet_type instead of the subtype that was not > recognized. This changes the debug message to print the subtype value. > > > diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c > > index 011cfdc47fab..270f8d6e2954 100644 > > --- a/net/batman-adv/distributed-arp-table.c > > +++ b/net/batman-adv/distributed-arp-table.c > > @@ -548,7 +548,7 @@ static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb, > > break; > > default: > > batadv_dbg(BATADV_DBG_DAT, bat_priv, "* type: Unknown (%u)!\n", > > - unicast_4addr_packet->u.packet_type); > > + unicast_4addr_packet->subtype); > > Discovered by: gpt-5-6-sol, opus-5 ยท Missed by: sashiko-gemini > Should this carry a Fixes: tag? > > The change corrects a real defect in batadv_dbg_arp(): the default arm of > the switch (unicast_4addr_packet->subtype) block was printing the outer > packet_type, which on that path is always BATADV_UNICAST_4ADDR, so the > message never showed the unknown value. [...] > Would adding > > Fixes: 5c3a0e553593 ("batman-adv: Distributed ARP Table - add ARP parsing functions") > > be appropriate here, so netdev and stable tooling can date the affected > history? The code change itself looks correct; only the missing tag stands > out. I am not allowed to add Fixes: lines for patches targeting net-next. See https://lore.kernel.org/all/7d73cd74-b040-4a3d-9d78-4ad8fc0a01f4@redhat.com/ Regards, Sven