[B.A.T.M.A.N.] [PATCH v2] batman-adv: Use octal permissions instead of macros

[B.A.T.M.A.N.] [PATCH v2] batman-adv: Use octal permissions instead of macros

[Sven Eckelmann]

Linus prefers to have octal permission numbers instead of combinations of
macro names ("random line noise"). Also old existing "bad symbolic
permission bit macro use" should be converted to octal numbers.
(http://lkml.kernel.org/r/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com)

Also remove the S_IFREG bit from the octal representation because it is
filtered out by debugfs_create.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
v2:
 - fix error in patch subject
---
 net/batman-adv/icmp_socket.c    | 4 ++--
 net/batman-adv/log.c            | 3 +--
 net/batman-adv/network-coding.c | 7 +++----
 3 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c
index 378cc11..aed8125 100644
--- a/net/batman-adv/icmp_socket.c
+++ b/net/batman-adv/icmp_socket.c
@@ -322,8 +322,8 @@ int batadv_socket_setup(struct batadv_priv *bat_priv)
 	if (!bat_priv->debug_dir)
 		goto err;
 
-	d = debugfs_create_file(BATADV_ICMP_SOCKET, S_IFREG | S_IWUSR | S_IRUSR,
-				bat_priv->debug_dir, bat_priv, &batadv_fops);
+	d = debugfs_create_file(BATADV_ICMP_SOCKET, 0600, bat_priv->debug_dir,
+				bat_priv, &batadv_fops);
 	if (!d)
 		goto err;
 
diff --git a/net/batman-adv/log.c b/net/batman-adv/log.c
index 56dc532..46b0725 100644
--- a/net/batman-adv/log.c
+++ b/net/batman-adv/log.c
@@ -212,8 +212,7 @@ int batadv_debug_log_setup(struct batadv_priv *bat_priv)
 	spin_lock_init(&bat_priv->debug_log->lock);
 	init_waitqueue_head(&bat_priv->debug_log->queue_wait);
 
-	d = debugfs_create_file("log", S_IFREG | S_IRUSR,
-				bat_priv->debug_dir, bat_priv,
+	d = debugfs_create_file("log", 0400, bat_priv->debug_dir, bat_priv,
 				&batadv_log_fops);
 	if (!d)
 		goto err;
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index e3baf69..0fc3b5f 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -1961,17 +1961,16 @@ int batadv_nc_init_debugfs(struct batadv_priv *bat_priv)
 	if (!nc_dir)
 		goto out;
 
-	file = debugfs_create_u8("min_tq", S_IRUGO | S_IWUSR, nc_dir,
-				 &bat_priv->nc.min_tq);
+	file = debugfs_create_u8("min_tq", 0644, nc_dir, &bat_priv->nc.min_tq);
 	if (!file)
 		goto out;
 
-	file = debugfs_create_u32("max_fwd_delay", S_IRUGO | S_IWUSR, nc_dir,
+	file = debugfs_create_u32("max_fwd_delay", 0644, nc_dir,
 				  &bat_priv->nc.max_fwd_delay);
 	if (!file)
 		goto out;
 
-	file = debugfs_create_u32("max_buffer_time", S_IRUGO | S_IWUSR, nc_dir,
+	file = debugfs_create_u32("max_buffer_time", 0644, nc_dir,
 				  &bat_priv->nc.max_buffer_time);
 	if (!file)
 		goto out;
-- 
2.9.3

Re: [B.A.T.M.A.N.] [v2] batman-adv: Use octal permissions instead of macros

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

On Donnerstag, 1. September 2016 10:25:12 CEST Sven Eckelmann wrote:
> Linus prefers to have octal permission numbers instead of combinations of
> macro names ("random line noise"). Also old existing "bad symbolic
> permission bit macro use" should be converted to octal numbers.
> (http://lkml.kernel.org/r/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMG
> Q@mail.gmail.com)
> 
> Also remove the S_IFREG bit from the octal representation because it is
> filtered out by debugfs_create.
> 
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v2:
>  - fix error in patch subject
> ---
>  net/batman-adv/icmp_socket.c    | 4 ++--
>  net/batman-adv/log.c            | 3 +--
>  net/batman-adv/network-coding.c | 7 +++----
>  3 files changed, 6 insertions(+), 8 deletions(-)

Applied in dec65f2333cb18c2cc28aa41709a7c35c89d1531 [1].

Kind regards,
	Sven

[1] https://git.open-mesh.org/batman-adv.git/commit/dec65f2333cb18c2cc28aa41709a7c35c89d1531

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]