From: Sven Eckelmann <sven@narfation.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH v3 3/3] batman-adv: avoid adding VLAN IDs 0 + 1 through kernel events
Date: Mon, 02 Dec 2024 13:48:09 +0100 [thread overview]
Message-ID: <23745634.6Emhk5qWAg@ripper> (raw)
In-Reply-To: <20241202053511.326-4-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]
On Monday, 2 December 2024 06:05:22 CET Linus Lüssing wrote:
> Currently the 8021q module always registers VLAN ID 0
To ensure that HW filters would forward priority frames. If you follow the
argumentation in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ad1afb00393915a51c21b1ae8704562bf036855f
then you can assume that the no-VLAN TT table entries should be used for
VLAN 0 because it is just for priority tagging - and not an actual VLAN.
> and the Linux
> bridge always registers VLAN ID 1 if bat0 is added to a bridge
> (probably as a quirk for hardware network/switch device drivers).
No, it is not a quirk. It just adds the default PVID of a bridge.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/bridge/br_vlan.c?id=e70140ba0d2b1a30467d4af6bcfe761327b9ec95#n1248
This sets as default PVID the 1:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/bridge/br_vlan.c?id=e70140ba0d2b1a30467d4af6bcfe761327b9ec95#n1218
And the default PVID could be changed by:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/bridge/br_vlan.c?id=e70140ba0d2b1a30467d4af6bcfe761327b9ec95#n1093
It will "disable" the PVID in case it is 0
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/bridge/br_vlan.c?id=e70140ba0d2b1a30467d4af6bcfe761327b9ec95#n1104
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-12-02 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 5:05 [PATCH v3 0/3] add dynamic, bridged-in TT VID detection support Linus Lüssing
2024-12-02 5:05 ` [PATCH v3 1/3] batman-adv: " Linus Lüssing
2024-12-02 5:05 ` [PATCH v3 2/3] batman-adv: limit number of learned VLANs from bridged-in clients Linus Lüssing
2025-01-05 8:04 ` Sven Eckelmann
2024-12-02 5:05 ` [PATCH v3 3/3] batman-adv: avoid adding VLAN IDs 0 + 1 through kernel events Linus Lüssing
2024-12-02 12:48 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23745634.6Emhk5qWAg@ripper \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox