From: Sven Eckelmann <sven@narfation.org>
To: Andreas Pape <APape@phoenixcontact.com>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] batctl: optchar variable uses wrong type
Date: Tue, 18 Oct 2016 14:30:44 +0200 [thread overview]
Message-ID: <2411339.8Jrj2ahkEz@bentobox> (raw)
In-Reply-To: <1473928860-30519-1-git-send-email-apape@phoenixcontact.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Donnerstag, 15. September 2016 10:41:00 CEST Andreas Pape wrote:
> The variable "optchar" used char instead of int leading to a non
> working batctl tp command as the while loop parsing the tp
> arguments with the getopt command is only left via the "default"
> case leaving the tp subcommand unusable. Using type char also
> lead to a compiler warning.
>
> Signed-off-by: Andreas Pape <apape@phoenixcontact.com>
> Reviewed-by: Sven Eckelmann <sven@narfation.org>
> ---
> tp_meter.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied in e397137aa9f4417ec21b4ba3db59b4f4e55b72fd [1]. The commit messages
was slightly modified to (hopefully) make it more readable.
Kind regards,
Sven
[1] https://git.open-mesh.org/batctl.git/commit/e397137aa9f4417ec21b4ba3db59b4f4e55b72fd
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-10-18 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 8:41 [B.A.T.M.A.N.] [PATCH] batctl: optchar variable uses wrong type Andreas Pape
2016-09-15 9:25 ` Sven Eckelmann
2016-09-15 12:02 ` [B.A.T.M.A.N.] Donations for domain registration fees open-mesh.net/open-mesh.org elektra
2016-09-15 12:30 ` Sven Eckelmann
2016-09-15 12:59 ` Simon Wunderlich
2016-10-18 12:30 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2411339.8Jrj2ahkEz@bentobox \
--to=sven@narfation.org \
--cc=APape@phoenixcontact.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox