From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH v2 1/2] batman-adv: BATMAN_V: introduce per hard-iface OGMv2 queues
Date: Sun, 04 Aug 2019 20:36:34 +0200 [thread overview]
Message-ID: <2424516.9MKKcQ5zTs@sven-edge> (raw)
In-Reply-To: <20190804180632.489-2-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Sunday, 4 August 2019 20:06:31 CEST Linus Lüssing wrote:
> + * @aggr_len: length of the OGM aggregate (excluding ethernet frame
> + * size)
Did you really mean "ethernet frame size" here? Not ethernet header size? At
least this would match following part of the second patch:
On Sunday, 4 August 2019 20:06:32 CEST Linus Lüssing wrote:
> + skb_aggr = dev_alloc_skb(aggr_len + ETH_HLEN + NET_IP_ALIGN);
> + if (!skb_aggr) {
> + batadv_v_ogm_aggr_list_free(hard_iface);
> + return;
> + }
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-04 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-04 18:06 [PATCH v2 0/2] batman-adv: BATMAN_V: OGMv2 packet aggregation Linus Lüssing
2019-08-04 18:06 ` [PATCH v2 1/2] batman-adv: BATMAN_V: introduce per hard-iface OGMv2 queues Linus Lüssing
2019-08-04 18:27 ` Sven Eckelmann
2019-08-04 18:29 ` Sven Eckelmann
2019-08-04 18:36 ` Sven Eckelmann [this message]
2019-08-04 18:06 ` [PATCH v2 2/2] batman-adv: BATMAN_V: aggregate OGMv2 packets Linus Lüssing
2019-08-04 18:25 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2424516.9MKKcQ5zTs@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox