From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Place kref_get near use of reference
Date: Fri, 15 Jul 2016 17:36:38 +0200 [thread overview]
Message-ID: <2523940.IGx5okD260@bentobox> (raw)
In-Reply-To: <6738075.DuRfZKd46c@voltaire>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
On Freitag, 15. Juli 2016 16:38:09 CEST Marek Lindner wrote:
> On Wednesday, June 29, 2016 23:44:54 Sven Eckelmann wrote:
> > net/batman-adv/bat_iv_ogm.c | 7 ++++---
> > net/batman-adv/bat_v_ogm.c | 5 ++---
> > net/batman-adv/bridge_loop_avoidance.c | 9 ++++-----
> > net/batman-adv/distributed-arp-table.c | 2 +-
> > net/batman-adv/gateway_client.c | 8 ++++++--
> > net/batman-adv/hard-interface.c | 6 ++----
> > net/batman-adv/network-coding.c | 9 ++++-----
> > net/batman-adv/originator.c | 8 ++++----
> > net/batman-adv/soft-interface.c | 4 ++++
> > net/batman-adv/translation-table.c | 6 +++---
> > net/batman-adv/tvlv.c | 9 +++++++++
> > 11 files changed, 43 insertions(+), 30 deletions(-)
>
> Could you please split this patch into smaller changes ? Mostly (not always)
> along files ?
I went through the change and it didn't made a lot of sense to split it per
file for some of the changes. So I split based on the type.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-07-15 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 21:44 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Place kref_get near use of reference Sven Eckelmann
2016-06-29 21:45 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix consistency of update route messages Sven Eckelmann
2016-07-15 8:38 ` Marek Lindner
2016-07-15 8:38 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Place kref_get near use of reference Marek Lindner
2016-07-15 15:36 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2523940.IGx5okD260@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox