From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv6 1/2] batman-adv: Remove dynamically allocated hashtables
Date: Tue, 21 Apr 2015 12:17:41 +0200 [thread overview]
Message-ID: <2545748.1iu2Ziffn3@bentobox> (raw)
In-Reply-To: <2772516.LYURaBhBM1@bentobox>
On Tuesday 21 April 2015 11:37:37 Sven Eckelmann wrote:
> On Tuesday 21 April 2015 10:42:42 Sven Eckelmann wrote:
> > It is unnecessary to allocate an extra memory region for hashtables and
> > the
> > corresponding locks. This brings the hashes used in batman-adv slightly in
> > the direction of the common statically sized hash table implementation.
> > More common hashtable functionality cannot be used batman-adv wide because
> > the simple hashtable and rhashtable implementations don't provide bucket
> > based locking.
>
> I was now informed that the rhashtable can now (Linux 4.0) support per
> bucket locks. The last statement is therefore wrong since the last Linux
> release.
I cannot find a good reason why David should accept such a patch. I will
therefore retract this patchset. The remaining patches will be rebased and
submitted later (during lunch time or this evening).
Kind regards,
Sven
prev parent reply other threads:[~2015-04-21 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 8:42 [B.A.T.M.A.N.] [PATCHv6 1/2] batman-adv: Remove dynamically allocated hashtables Sven Eckelmann
2015-04-21 8:42 ` [B.A.T.M.A.N.] [PATCHv6 2/2] batman-adv: Define the size of hashtables by hash bits Sven Eckelmann
2015-04-21 9:37 ` [B.A.T.M.A.N.] [PATCHv6 1/2] batman-adv: Remove dynamically allocated hashtables Sven Eckelmann
2015-04-21 10:17 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2545748.1iu2Ziffn3@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).