From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Sven Eckelmann Date: Tue, 21 Apr 2015 12:17:41 +0200 Message-ID: <2545748.1iu2Ziffn3@bentobox> In-Reply-To: <2772516.LYURaBhBM1@bentobox> References: <1429605763-17186-1-git-send-email-sven@narfation.org> <2772516.LYURaBhBM1@bentobox> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [B.A.T.M.A.N.] [PATCHv6 1/2] batman-adv: Remove dynamically allocated hashtables Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: b.a.t.m.a.n@lists.open-mesh.org On Tuesday 21 April 2015 11:37:37 Sven Eckelmann wrote: > On Tuesday 21 April 2015 10:42:42 Sven Eckelmann wrote: > > It is unnecessary to allocate an extra memory region for hashtables and > > the > > corresponding locks. This brings the hashes used in batman-adv slightly in > > the direction of the common statically sized hash table implementation. > > More common hashtable functionality cannot be used batman-adv wide because > > the simple hashtable and rhashtable implementations don't provide bucket > > based locking. > > I was now informed that the rhashtable can now (Linux 4.0) support per > bucket locks. The last statement is therefore wrong since the last Linux > release. I cannot find a good reason why David should accept such a patch. I will therefore retract this patchset. The remaining patches will be rebased and submitted later (during lunch time or this evening). Kind regards, Sven