Re: [B.A.T.M.A.N.] Patch to add mesh_no_rebroadcast

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 3607 bytes --]

On Sunday 17 May 2015 11:16:59 Ruben Wisniewski wrote:
> Am Sun, 17 May 2015 09:11:18 +0200
> 
> schrieb Sven Eckelmann <sven@narfation.org>:
> > > Why are you sending a patch from Linus? And this patch doesn't
> > > apply on current master or next.
> > 
> > Just to make it more clear: I think it is not a problem to pick up
> > some old patch from someone else when the original author has no
> > problem with it. But taking a patch from someone else and then
> > without any additional information claiming to be the author is a
> > rather bad move.
> 
> It is a old patch which is fixed to apply to the latest stable version.
> 
> I talk to Simon yesterday, that it would be nice if the freifunker does
> not need to ship this patch in any installation, since we start to setup
> custom repos with this patch included and so on...
> 
> Else all freifunk-firmwares include this patch, this should be stable.

Still not a reason to drop the original author information from the patch. See 
https://www.kernel.org/doc/Documentation/SubmittingPatches under "11) Sign 
your work" for information how your modifications to the original patch could 
be documented inside the Signed-off-by part without removing the original 
authorship.

See under https://www.kernel.org/doc/Documentation/SubmittingPatches "14) The 
canonical patch format" to find out how the authorship of a patch is 
"calculated" (right under the "Subject" part of this section).

> > It is even worse that the informative commit subject + message was
> > dropped. There is also no information what you've changed before your
> > signed-off-by (which is also missing).
> 
> Yes, I removed it, since the last patches I found on this mailinglist
> does not have this information-part.

Could not find a different version of this patch on this mailing list. So 
there is no reason to drop it yourself without documenting it somewhere.

And the last patches I see on the mailing list (besides the ones from you) 
are:

 * https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-May/013106.html
 * https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-May/013108.html
 * https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-May/013109.html
 * https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-April/013068.html
 * https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-April/013066.html
 * https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-April/013065.html
 * https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-April/013064.html
 * https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2015-April/013061.html

The only patches which don't have a long description are patches to the compat 
code, trivial checkpatch changes and the copyright stuff (sry, I refuse to 
explain why the year has changed). The compat patch without description 
doesn't will not be submitted to the Linux networking subsystem maintainer. 
And since it doesn't fix anything, the text to describe the change would be 
rather uninteresting.

I think original commit message from Linus for this patch has vital 
information to understand what the new option does, why it is needed and in 
which situation it can be used/not be used.

> So I thought this is the given
> form for this mailinglist. (There is no information about that on the
> mailinglist site).

This is not about the mailing list directly. The contributing information can 
be found under:

 * https://www.open-mesh.org/projects/open-mesh/wiki/Contribute
 * https://www.kernel.org/doc/Documentation/SubmittingPatches
 * https://www.kernel.org/doc/Documentation/CodingStyle

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]