From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: always assume 2-byte packet alignment
Date: Sat, 03 Feb 2018 09:40:53 +0100 [thread overview]
Message-ID: <2600801.iuZaCSQALx@sven-edge> (raw)
In-Reply-To: <2157409.R7zQT89qM7@bentobox>
[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]
On Mittwoch, 24. Januar 2018 14:40:03 CET Sven Eckelmann wrote:
[...]
> I know your intentions and I understand the problem. But there is the chance
> that David Miller will reject this patch - like he did it some years ago
> with a similar (not the same) patch:
>
> "I'm not applying this, please try work to implement this more
> acceptably first." [1]
>
> But maybe he has now some other opinion because the unaligned problem is
> caused by the encapsulation in VXLAN or maybe he has a better idea. At
> least VXLAN encap stuff should affect a lot more net code than batman-adv.
[...]
Looks like we have to assume that David has nothing against the patch and we
should get the patch integrated.
Affected are any kind of access to the 32 bit values:
* &batadv_ogm_packet->seqno
* &batadv_ogm2_packet->seqno
* &batadv_ogm2_packet->throughput
* &batadv_elp_packet->seqno
* &batadv_elp_packet->elp_interval
* &batadv_icmp_tp_packet->seqno
* &batadv_icmp_tp_packet->timestamp
* &batadv_tvlv_gateway_data->bandwidth_down
* &batadv_tvlv_gateway_data->bandwidth_up
* &batadv_tvlv_tt_vlan_data->crc
I personally would love to hear that there is a better way to fix this
problem. But either this or something like the (out of tree) hacks from
OpenWrt [1] seem to be required to work around this problem.
Kind regards,
Sven
[1] https://github.com/openwrt/openwrt/blob/master/target/linux/ar71xx/patches-4.9/910-unaligned_access_hacks.patch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-03 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 11:21 [B.A.T.M.A.N.] [PATCH RFC] batman-adv: always assume 2-byte packet alignment Matthias Schiffer
2018-01-24 13:40 ` [B.A.T.M.A.N.] [RFC] " Sven Eckelmann
2018-02-03 8:40 ` Sven Eckelmann [this message]
2018-03-05 6:32 ` [B.A.T.M.A.N.] [PATCH RFC] " Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2600801.iuZaCSQALx@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox