Re: [B.A.T.M.A.N.] [PATCH-maint v2] batman-adv: lock crc access in bridge loop avoidance

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Friday, September 11, 2015 18:04:13 Simon Wunderlich wrote:
> We have found some networks in which nodes were constantly requesting
> other nodes BLA claim tables to synchronize, just to ask for that again
> once completed. The reason was that the crc checksum of the asked nodes
> were out of sync due to missing locking and multiple writes to the same
> crc checksum when adding/removing entries. Therefore the asked nodes
> constantly reported the wrong crc, which caused repeating requests.
> 
> To avoid multiple functions changing a backbone gateways crc entry at
> the same time, lock it using a spinlock.
> 
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
> Tested-by: Alfons Name <AlfonsName@web.de>
> ---
> Changes to PATCH-maint:
>  * fix spin_lock -> spin_unlock in claim table printing (thanks Petr)
> ---
>  net/batman-adv/bridge_loop_avoidance.c | 35
> +++++++++++++++++++++++++++++-----
> net/batman-adv/types.h                 |  2 ++
>  2 files changed, 32 insertions(+), 5 deletions(-)

Applied in revision b307e72.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]