From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v2 16/18] batman-adv: Place kref_get for nc_path near use
Date: Tue, 19 Jul 2016 16:44:13 +0800 [thread overview]
Message-ID: <2691799.8DyBiIpzMl@voltaire> (raw)
In-Reply-To: <1468597173-25378-16-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Friday, July 15, 2016 17:39:31 Sven Eckelmann wrote:
> It is hard to understand why the refcnt is increased when it isn't done
> near the actual place the new reference is used. So using kref_get right
> before the place which requires the reference and in the same function
> helps to avoid accidental problems causedy incorrect reference counting.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v2:
> - split patch based on type
>
> net/batman-adv/network-coding.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied in revision 8427a98.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-19 8:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 15:39 [B.A.T.M.A.N.] [PATCH v2 01/18] batman-adv: Place kref_get for orig_node_vlan near use Sven Eckelmann
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 02/18] batman-adv: Place kref_get for orig_ifinfo " Sven Eckelmann
2016-07-19 8:08 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 03/18] batman-adv: Place kref_get for tt_orig_list_entry " Sven Eckelmann
2016-07-19 8:09 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 04/18] batman-adv: Place kref_get for neigh_ifinfo " Sven Eckelmann
2016-07-19 8:09 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 05/18] batman-adv: Place kref_get for neigh_node " Sven Eckelmann
2016-07-19 8:10 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 06/18] batman-adv: Place kref_get for orig_node " Sven Eckelmann
2016-07-19 8:25 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 07/18] batman-adv: Place kref_get for tt_local_entry " Sven Eckelmann
2016-07-19 8:26 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 08/18] batman-adv: Place kref_get for tt_common " Sven Eckelmann
2016-07-19 8:27 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 09/18] batman-adv: Place kref_get for bla_claim " Sven Eckelmann
2016-07-19 8:29 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 10/18] batman-adv: Place kref_get for bla_backbone_gw " Sven Eckelmann
2016-07-19 8:30 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 11/18] batman-adv: Place kref_get for dat_entry " Sven Eckelmann
2016-07-19 8:30 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 12/18] batman-adv: Place kref_get for gw_node " Sven Eckelmann
2016-07-19 8:34 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 13/18] batman-adv: Place kref_get for hard_iface " Sven Eckelmann
2016-07-19 8:40 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 14/18] batman-adv: Place kref_get for softif_vlan " Sven Eckelmann
2016-07-19 8:42 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 15/18] batman-adv: Place kref_get for nc_node " Sven Eckelmann
2016-07-19 8:43 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 16/18] batman-adv: Place kref_get for nc_path " Sven Eckelmann
2016-07-19 8:44 ` Marek Lindner [this message]
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 17/18] batman-adv: Place kref_get for tvlv_container " Sven Eckelmann
2016-07-19 8:45 ` Marek Lindner
2016-07-15 15:39 ` [B.A.T.M.A.N.] [PATCH v2 18/18] " Sven Eckelmann
2016-07-19 8:41 ` Sven Eckelmann
2016-07-19 8:46 ` [B.A.T.M.A.N.] [PATCH v2 18/18] batman-adv: Place kref_get for tvlv_handler " Marek Lindner
2016-07-19 8:07 ` [B.A.T.M.A.N.] [PATCH v2 01/18] batman-adv: Place kref_get for orig_node_vlan " Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2691799.8DyBiIpzMl@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox