From: Simon Wunderlich <sw@simonwunderlich.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: b.a.t.m.a.n@lists.open-mesh.org, Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCH 3/3] alfred: Mount debugfs before reducing capabilities
Date: Thu, 10 Mar 2016 16:09:18 +0100 [thread overview]
Message-ID: <26995374.rRgDESDE4R@prime> (raw)
In-Reply-To: <20160202022512.GE12673@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Hi Andrew,
On Tuesday 02 February 2016 03:25:12 Andrew Lunn wrote:
> On Fri, Jan 29, 2016 at 01:14:53PM +0100, Simon Wunderlich wrote:
> > On Thursday 28 January 2016 04:53:15 Andrew Lunn wrote:
> [...]
> > > @@ -160,6 +161,9 @@ static struct globals *alfred_init(int argc, char
> > > *argv[]) {NULL, 0, NULL, 0},
> > >
> > > };
> > >
> > > + /* We need full capabilities to mount debugfs, so do that now */
> > > + debugfs_mount(NULL);
> > > +
> > >
> > > ret = reduce_capabilities();
> > > if (ret < 0)
> > >
> > > return NULL;
> >
> > Can't we remove the other calls to debugfs_mount() ? I see 3 more calls in
> > alfred ...
>
> Yes, the other calls within this binary are probably failing, due to
> reduced capabilities. I can remove them in a v3 patch.
>
> Andrew
Are you still planning on sending a fixed patchset? :)
Thanks!
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-10 15:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 3:53 [B.A.T.M.A.N.] [PATCH 1/3] alfred: vis: Use debugfs_make_path helper Andrew Lunn
2016-01-28 3:53 ` [B.A.T.M.A.N.] [PATCH 2/3] alfred: Add support for network namespaces Andrew Lunn
2016-01-29 12:18 ` Simon Wunderlich
2016-02-02 2:22 ` Andrew Lunn
2016-01-28 3:53 ` [B.A.T.M.A.N.] [PATCH 3/3] alfred: Mount debugfs before reducing capabilities Andrew Lunn
2016-01-29 12:14 ` Simon Wunderlich
2016-02-02 2:25 ` Andrew Lunn
2016-03-10 15:09 ` Simon Wunderlich [this message]
2016-03-10 15:49 ` Andrew Lunn
2016-03-11 13:48 ` [B.A.T.M.A.N.] [PATCH 1/3] alfred: vis: Use debugfs_make_path helper Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26995374.rRgDESDE4R@prime \
--to=sw@simonwunderlich.de \
--cc=a@unstable.cc \
--cc=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox