From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>,
Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix lock for ogm cnt access in batadv_iv_ogm_calc_tq
Date: Mon, 04 Dec 2017 12:59:50 +0100 [thread overview]
Message-ID: <2742240.Flf4YFj6lS@prime> (raw)
In-Reply-To: <20171203102645.5490-1-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
On Sunday, December 3, 2017 11:26:45 AM CET Sven Eckelmann wrote:
> The originator node object orig_neigh_node is used to when accessing the
> bcast_own(_sum) and real_packet_count information. The access to them has
> to be protected with the spinlock in orig_neigh_node.
>
> But the function uses the lock in orig_node instead. This is incorrect
> because they could be two different originator node objects.
>
> Fixes: f14416760b62 ("batman-adv: protect bit operations to count OGMs with
> spinlock") Signed-off-by: Sven Eckelmann <sven@narfation.org>
Applied in 9a3b1954.
Thank you,
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-12-04 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 10:26 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix lock for ogm cnt access in batadv_iv_ogm_calc_tq Sven Eckelmann
2017-12-04 11:59 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2742240.Flf4YFj6lS@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox